From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH v2 01/15] KVM: MMU: fix the count of spte number Date: Sun, 8 Sep 2013 17:01:49 +0300 Message-ID: <20130908140149.GA6468@redhat.com> References: <1378376958-27252-1-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <1378376958-27252-2-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <20130908121917.GH17294@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Xiao Guangrong , avi.kivity@gmail.com, mtosatti@redhat.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Xiao Guangrong Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Sun, Sep 08, 2013 at 09:55:04PM +0800, Xiao Guangrong wrote: > > On Sep 8, 2013, at 8:19 PM, Gleb Natapov wrote: > > > On Thu, Sep 05, 2013 at 06:29:04PM +0800, Xiao Guangrong wrote: > >> If the desc is the last one and it is full, its sptes is not counted > >> > > Hmm, if desc is not full but it is not the last one all sptes after the > > desc are not counted too. > > But the desc must be the last one if it's not full since we always add > new entry or delete entry from the last desc. > Why do we alway delete entries from last desc? We delete them from the desc we found them in. Current code does not try to move entries between descs, only inside a desc. -- Gleb.