From: Gleb Natapov <gleb@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 3/4] KVM: nVMX: Check all exceptions for intercept during delivery to L2
Date: Wed, 25 Sep 2013 14:52:14 +0300 [thread overview]
Message-ID: <20130925115214.GJ1445@redhat.com> (raw)
In-Reply-To: <5242C833.80609@redhat.com>
On Wed, Sep 25, 2013 at 01:25:39PM +0200, Paolo Bonzini wrote:
> Il 25/09/2013 13:00, Gleb Natapov ha scritto:
> >>> > > @@ -1921,8 +1920,7 @@ static void vmx_queue_exception(struct kvm_vcpu *vcpu, unsigned nr,
> >>> > > struct vcpu_vmx *vmx = to_vmx(vcpu);
> >>> > > u32 intr_info = nr | INTR_INFO_VALID_MASK;
> >>> > >
> >>> > > - if (!reinject && nr == PF_VECTOR && is_guest_mode(vcpu) &&
> >>> > > - !vmx->nested.nested_run_pending && nested_pf_handled(vcpu))
> >>> > > + if (!reinject && is_guest_mode(vcpu) && nested_ex_handled(vcpu, nr))
> >> >
> >> > The code is now pretty similar to what svm.c does. Do we want to move
> >> > the is_guest_mode(vcpu) check into nested_ex_handled, too? (Or vice
> >> > versa, take it out in svm.c). Perhaps you could also name the function
> >> > nested_vmx_check_exception.
> >> >
> > I want to try to move the logic into common code eventually. I do not
> > mind renaming for now, but it will have to wait for the next week :)
>
> I can rename while applying the patch. Making more logic common to vmx
> and svm can wait.
>
Yes, of course, logic unification is not for the immediate feature.
--
Gleb.
next prev parent reply other threads:[~2013-09-25 11:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 9:51 [PATCH 0/4] Fix shadow-on-shadow nested VMX Gleb Natapov
2013-09-25 9:51 ` [PATCH 1/4] KVM: nVMX: Amend nested_run_pending logic Gleb Natapov
2013-09-25 9:51 ` [PATCH 2/4] KVM: nVMX: Do not put exception that caused vmexit to IDT_VECTORING_INFO Gleb Natapov
2013-09-25 9:51 ` [PATCH 3/4] KVM: nVMX: Check all exceptions for intercept during delivery to L2 Gleb Natapov
2013-09-25 10:38 ` Paolo Bonzini
2013-09-25 11:00 ` Gleb Natapov
2013-09-25 11:25 ` Paolo Bonzini
2013-09-25 11:52 ` Gleb Natapov [this message]
2013-09-25 14:00 ` Paolo Bonzini
2013-09-25 14:19 ` Gleb Natapov
2013-09-25 14:22 ` Paolo Bonzini
2013-09-25 16:31 ` Gleb Natapov
2013-09-25 9:51 ` [PATCH 4/4] KVM: nVMX: Do not generate #DF if #PF happens during exception delivery into L2 Gleb Natapov
2013-09-25 11:24 ` Paolo Bonzini
2013-09-25 11:51 ` Gleb Natapov
2013-09-25 12:08 ` Paolo Bonzini
2013-09-25 12:21 ` Gleb Natapov
2013-09-25 13:26 ` Paolo Bonzini
2013-09-25 13:36 ` Gleb Natapov
2013-09-25 13:53 ` Paolo Bonzini
2013-09-26 15:10 ` [PATCH 0/4] Fix shadow-on-shadow nested VMX Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925115214.GJ1445@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).