From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 3/4] KVM: nVMX: Check all exceptions for intercept during delivery to L2 Date: Wed, 25 Sep 2013 19:31:22 +0300 Message-ID: <20130925163122.GD30317@redhat.com> References: <1380102696-25267-1-git-send-email-gleb@redhat.com> <1380102696-25267-4-git-send-email-gleb@redhat.com> <5242EC70.6010003@redhat.com> <20130925141948.GC30317@redhat.com> <5242F1B8.6040506@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13054 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967Ab3IYQbZ (ORCPT ); Wed, 25 Sep 2013 12:31:25 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8PGVOeg011781 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 Sep 2013 12:31:24 -0400 Content-Disposition: inline In-Reply-To: <5242F1B8.6040506@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Sep 25, 2013 at 04:22:48PM +0200, Paolo Bonzini wrote: > Il 25/09/2013 16:19, Gleb Natapov ha scritto: > >>> > > -static int nested_pf_handled(struct kvm_vcpu *vcpu) > >>> > > +static int nested_ex_handled(struct kvm_vcpu *vcpu, unsigned nr) > >>> > > { > >>> > > struct vmcs12 *vmcs12 = get_vmcs12(vcpu); > >>> > > > >>> > > - /* TODO: also check PFEC_MATCH/MASK, not just EB.PF. */ > >> > > >> > Just one more question, why drop this comment? It doesn't seem > >> > incorrect in the particular case where nr == PF_VECTOR. > > > > I moved it to vmx_inject_page_fault_nested(). > > Ah, so if you test it there, you shouldn't get here unless the > PFEC_MASK/MATCH matches. Yes, PF will never reach here in case of shadow on shadow. -- Gleb.