From: Christoffer Dall <christoffer.dall@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, gleb@redhat.com
Subject: Re: [PATCH 6/9] Introduce virtio-testdev
Date: Thu, 17 Oct 2013 12:01:05 -0700 [thread overview]
Message-ID: <20131017190105.GS24837@cbox> (raw)
In-Reply-To: <20131017095126.GB2172@hawk.usersys.redhat.com>
On Thu, Oct 17, 2013 at 11:51:26AM +0200, Andrew Jones wrote:
> On Wed, Oct 16, 2013 at 06:06:14PM -0700, Christoffer Dall wrote:
> > There's an interesting mix of space and tab indentations in this file...
> >
> > I assume using the kernel coding style would be approprate here...
> > Actually, that could be added to the readme too. (Or whichever format we
> > choose).
> >
> > Could you fix?
>
> I was attempting to adopt the style from the common code lib/*, see
> lib/string.c, lib/printf.c, lib/argv,c. The style used there is
>
> 1. 'four spaces'
> 2. 'tab'
> 3. 'tab + four spaces'
> 4. 'tab + tab'
> ...
that sounds like the most horrible broken coding style I have ever heard
of. At least it reads like sh*t in mutt.
>
> However, I'd actually prefer to use the kernel style as well, and I see
> that not even those three common files are consistent. argv.c only uses
> spaces. Other x86 files also have a variety of styles (kernel style
> being one of them). So probably the best choice is to go with kernel
> style, and to add another cleanup patch that changes lib/* files as
> well.
>
> > > + for (i = 0; i < m->nr; ++i) {
> > > + volatile u32 *base = (u32 *)compat_ptr(m->addrs[i]);
> > > + u32 devid32 = base[VIRTIO_MMIO_DEVICEID / 4];
Yeah, I think it's is by far the easiest and most convenient for
everyone.
> >
> > do we have readl/writel in this framework? If not, maybe we should to
> > indicate IO read/writes and ensure the compiler doesn't reorder things
> > and that we have the necessary memory barriers etc...?
> >
> > That would apply to virtio_testdev above as well.
>
> OK, I agree it makes sense to add readl and writel in. I'll do that, and
> then rework my mmio reads to use them.
>
> > + printf("Refusing to run with virtio-testdev major = %d, minor = %d\n",
> > + major, minor);
>
> > "Refusing to run"?
> > How about "incompatible version of virtio-testdev"?
>
> Sure. OK.
>
> drew
next prev parent reply other threads:[~2013-10-17 19:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 16:23 [PATCH 0/9] kvm-unit-tests/arm: initial drop Andrew Jones
2013-10-14 16:23 ` [PATCH 1/9] remove unused files Andrew Jones
2013-10-16 12:52 ` Gleb Natapov
2013-10-16 13:13 ` Alexander Graf
2013-10-16 13:18 ` Andrew Jones
2013-10-14 16:23 ` [PATCH 2/9] makefile and run_tests tweaks Andrew Jones
2013-10-14 16:23 ` [PATCH 3/9] clean root dir of all x86-ness Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 9:35 ` Andrew Jones
2013-10-17 19:01 ` Christoffer Dall
2013-10-20 16:37 ` Andrew Jones
2013-10-14 16:23 ` [PATCH 4/9] Introduce a simple iomap structure Andrew Jones
2013-10-14 16:23 ` [PATCH 5/9] Add halt() and some error codes Andrew Jones
2013-10-14 16:23 ` [PATCH 6/9] Introduce virtio-testdev Andrew Jones
2013-10-15 8:39 ` Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 9:51 ` Andrew Jones
2013-10-17 19:01 ` Christoffer Dall [this message]
2013-10-17 1:06 ` Christoffer Dall
2013-10-14 16:23 ` [PATCH 7/9] arm: replace arbitrary divisions Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 10:03 ` Andrew Jones
2013-10-17 18:59 ` Christoffer Dall
2013-10-14 16:23 ` [PATCH 8/9] arm: initial drop Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 10:16 ` Andrew Jones
2013-10-17 13:28 ` Andrew Jones
2013-10-17 18:39 ` Christoffer Dall
2013-10-14 16:23 ` [PATCH 9/9] arm: add vectors support Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 10:38 ` Andrew Jones
2013-10-17 18:58 ` Christoffer Dall
2013-10-20 16:35 ` Andrew Jones
2013-10-21 9:59 ` Christoffer Dall
2013-11-20 23:06 ` [PATCH 0/9] kvm-unit-tests/arm: initial drop María Soler Heredia
2013-11-26 17:23 ` Andrew Jones
2013-12-29 9:24 ` Christoffer Dall
2014-01-02 18:56 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017190105.GS24837@cbox \
--to=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox