From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 3.12-rc7] KVM: Fix modprobe failure for kvm_intel/kvm_amd Date: Wed, 30 Oct 2013 08:59:30 -0700 Message-ID: <20131030155930.GA23433@kroah.com> References: <1383059634-55512-1-git-send-email-tim.gardner@canonical.com> <52700C24.9050001@linux.vnet.ibm.com> <52711121.9030606@linux.vnet.ibm.com> <20131030142359.GA32196@kroah.com> <5271284A.6000002@linux.vnet.ibm.com> <527129D4.3010308@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Raghavendra K T , Linus Torvalds , Tim Gardner , Linux Kernel Mailing List , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Gleb Natapov , Marcelo Tosatti , KVM list , Al Viro To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <527129D4.3010308@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Oct 30, 2013 at 04:46:28PM +0100, Paolo Bonzini wrote: > Il 30/10/2013 16:39, Raghavendra K T ha scritto: > >> > >> Why even error out at all here? You should never care about debugfs > >> file creation return values, so why pass any error back up the stack? > > > > We could change this to return 0, but we will still be left with > > kvm_main.c: kvm_init_debug() function which creates the kvm debugfs > > directory. (I thought Paolo and Gleb's ack would be needed for > > that change since it would be a bigger decision for me) > > > > So I just made the patch to fix only Linus's concern. > > Even if it is okay to exit and not create the files (and I think it's a > bit surprising), I'd like at least a printk to signal what's happening. > But there should be no reason for debugfs directory creation to fail in > the end, except for basic mistakes such as the one that Tim reported, so > I think it's better to report the failure. Creation will "fail" if debugfs is not enabled, so spiting out printk messages in that case is not a good idea. greg k-h