public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: kvm unit test fails to build on 32 bit systems
Date: Mon, 11 Nov 2013 20:48:23 +0200	[thread overview]
Message-ID: <20131111184823.GC15084@redhat.com> (raw)
In-Reply-To: <20131111184715.GA24276@redhat.com>

On Mon, Nov 11, 2013 at 08:47:15PM +0200, Michael S. Tsirkin wrote:
> On Mon, Nov 11, 2013 at 06:59:51PM +0200, Gleb Natapov wrote:
> > On Mon, Nov 11, 2013 at 06:34:01PM +0200, Michael S. Tsirkin wrote:
> > > x86/eventinj.c: Assembler messages:
> > > x86/eventinj.c:151: Error: bad register name `%rsp'
> > > x86/eventinj.c:152: Error: bad register name `%rsp'
> > > 
> > How about that?
> 
> 
> works for me.
> 
> Tested-by: Michael S. Tsirkin <mst@redhat.com>
> 
> 

Signed-off-by: Gleb Natapov <gleb@redhat.com>
> > diff --git a/x86/eventinj.c b/x86/eventinj.c
> > index 3d36b37..9d4392c 100644
> > --- a/x86/eventinj.c
> > +++ b/x86/eventinj.c
> > @@ -148,8 +148,8 @@ static void nmi_iret_isr(struct ex_regs *r)
> >  	s[2] = read_rflags();
> >  	s[1] = read_cs();
> >  	s[0] = after_iret_addr = (unsigned long)&&after_iret;
> > -	asm ("mov %%rsp, %0\n\t"
> > -	     "mov %1, %%rsp\n\t"
> > +	asm ("mov %%" R "sp, %0\n\t"
> > +	     "mov %1, %%" R "sp\n\t"
> >  	     "outl %2, $0xe4\n\t" /* flush stack page */
> >  #ifdef __x86_64__
> >  	     "iretq\n\t"
> > --
> > 			Gleb.

--
			Gleb.

  reply	other threads:[~2013-11-11 18:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 16:34 kvm unit test fails to build on 32 bit systems Michael S. Tsirkin
2013-11-11 16:59 ` Gleb Natapov
2013-11-11 18:47   ` Michael S. Tsirkin
2013-11-11 18:48     ` Gleb Natapov [this message]
2013-11-18 19:02       ` Michael S. Tsirkin
2013-11-18 19:05         ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131111184823.GC15084@redhat.com \
    --to=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox