From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH for-1.7] target-i386: Fix build by providing stub
 kvm_arch_get_supported_cpuid()
Date: Tue, 12 Nov 2013 15:26:49 +0200
Message-ID: <20131112132649.GC2008@redhat.com>
References: <1384204922-8250-1-git-send-email-peter.maydell@linaro.org>
 <5281580D.7060305@redhat.com>
 <CAFEAcA9oxAGZ3h-qkO32WJ-3TSZwMquYBfVhJ=oUqgBX8rqiow@mail.gmail.com>
 <52816422.8060002@redhat.com>
 <CA+aC4ksHwQnyYoofHd8U_uRarcB7Ynr_ekCVmYovaj7KnhHhfQ@mail.gmail.com>
 <CAFEAcA8UjSRze-Zz1jdE2sS0GM5ihfoN5Dz6Gj8MPF_iXUOewA@mail.gmail.com>
 <52821A62.2050001@redhat.com>
 <CAFEAcA8huEkY5pkiwCseXBBugOidXQBMS0HBoRWqsOhHxU7r2g@mail.gmail.com>
 <52822958.8060508@redhat.com>
 <CAFEAcA--SoGzm8+y5T4yKgsa8DP98Btj-G8pFqJo2Qki94L5CA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	QEMU Developers <qemu-devel@nongnu.org>,
	kvm-devel <kvm@vger.kernel.org>,
	Patch Tracking <patches@linaro.org>,
	Andreas Tobler <andreast@freebsd.org>,
	Anthony Liguori <aliguori@amazon.com>
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:46901 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755246Ab3KLN0y (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 12 Nov 2013 08:26:54 -0500
Content-Disposition: inline
In-Reply-To: <CAFEAcA--SoGzm8+y5T4yKgsa8DP98Btj-G8pFqJo2Qki94L5CA@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Nov 12, 2013 at 01:21:51PM +0000, Peter Maydell wrote:
>                                              (Similarly,
> you can put code that's a syntax error inside #if 0,
> but that won't work inside an "if (0)". The solution
> is not to do that.)
> 
That's the advantage of using "if (0)" instead of  #if 0. You do not
need to enable insane amount of options to check that your change does
not break complication for any of them.

--
			Gleb.