From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH] arm/arm64: KVM: Fix hyp mappings of vmalloc regions
Date: Sat, 16 Nov 2013 09:15:24 -0800
Message-ID: <20131116171524.GK20516@lvm>
References: <1384557880-14107-1-git-send-email-christoffer.dall@linaro.org>
 <87846f3195cadcae32824120f78e3c9d@www.loen.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, patches@linaro.org
To: Marc Zyngier <marc.zyngier@arm.com>,
	"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pd0-f179.google.com ([209.85.192.179]:45298 "EHLO
	mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751222Ab3KPRP0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 16 Nov 2013 12:15:26 -0500
Received: by mail-pd0-f179.google.com with SMTP id r10so1832919pdi.24
        for <kvm@vger.kernel.org>; Sat, 16 Nov 2013 09:15:26 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <87846f3195cadcae32824120f78e3c9d@www.loen.fr>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sat, Nov 16, 2013 at 10:01:01AM +0000, Marc Zyngier wrote:
> On 2013-11-15 23:24, Christoffer Dall wrote:
> >Using virt_to_phys on percpu mappings is horribly wrong as it may be
> >backed by vmalloc.  Introduce kvm_kaddr_to_phys which translates both
> >types of valid kernel addresses to the corresponding physical
> >address.
> >
> >At the same time resolves a typing issue where we were storing the
> >physical address as a 32 bit unsigned long (on arm), truncating the
> >physical address for addresses above the 4GB limit.  This caused
> >breakage on Keystone.
> >
> >Reported-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> >Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> >---
> >
> >This patch is loosely based on Marc's previous patch from today but
> >instead of introducing another Hyp mapping function, it fixes the
> >existing one to deal with both kinds of kernel addresses.
> 
> Looks good to me! This should probably be merged quickly (after
> testing by Santosh), and possibly Cc-ed to stable.
> 
Agreed, Santhos, can you give this a quick spin?

-Christoffer