From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: kvm unit test fails to build on 32 bit systems
Date: Mon, 18 Nov 2013 21:02:39 +0200
Message-ID: <20131118190239.GA32527@redhat.com>
References: <20131111163400.GA21040@redhat.com>
 <20131111165951.GA15084@redhat.com>
 <20131111184715.GA24276@redhat.com>
 <20131111184823.GC15084@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>, pbonzini@redhat.com
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:9470 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752082Ab3KRS7b (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 18 Nov 2013 13:59:31 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAIIxUBo003458
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Mon, 18 Nov 2013 13:59:30 -0500
Content-Disposition: inline
In-Reply-To: <20131111184823.GC15084@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Nov 11, 2013 at 08:48:23PM +0200, Gleb Natapov wrote:
> On Mon, Nov 11, 2013 at 08:47:15PM +0200, Michael S. Tsirkin wrote:
> > On Mon, Nov 11, 2013 at 06:59:51PM +0200, Gleb Natapov wrote:
> > > On Mon, Nov 11, 2013 at 06:34:01PM +0200, Michael S. Tsirkin wrote:
> > > > x86/eventinj.c: Assembler messages:
> > > > x86/eventinj.c:151: Error: bad register name `%rsp'
> > > > x86/eventinj.c:152: Error: bad register name `%rsp'
> > > > 
> > > How about that?
> > 
> > 
> > works for me.
> > 
> > Tested-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > 
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>

Can this be applied please?

> > > diff --git a/x86/eventinj.c b/x86/eventinj.c
> > > index 3d36b37..9d4392c 100644
> > > --- a/x86/eventinj.c
> > > +++ b/x86/eventinj.c
> > > @@ -148,8 +148,8 @@ static void nmi_iret_isr(struct ex_regs *r)
> > >  	s[2] = read_rflags();
> > >  	s[1] = read_cs();
> > >  	s[0] = after_iret_addr = (unsigned long)&&after_iret;
> > > -	asm ("mov %%rsp, %0\n\t"
> > > -	     "mov %1, %%rsp\n\t"
> > > +	asm ("mov %%" R "sp, %0\n\t"
> > > +	     "mov %1, %%" R "sp\n\t"
> > >  	     "outl %2, $0xe4\n\t" /* flush stack page */
> > >  #ifdef __x86_64__
> > >  	     "iretq\n\t"
> > > --
> > > 			Gleb.
> 
> --
> 			Gleb.