From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH 5/9] Introduce libio to common code for io read/write Date: Thu, 2 Jan 2014 19:38:35 +0100 Message-ID: <20140102183835.GK9725@hawk.usersys.redhat.com> References: <1386175377-23086-1-git-send-email-drjones@redhat.com> <1386175377-23086-6-git-send-email-drjones@redhat.com> <20131229063035.GD13601@cbox> <20140102154721.GD9725@hawk.usersys.redhat.com> <20140102171930.GD27806@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13411 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752529AbaABSih (ORCPT ); Thu, 2 Jan 2014 13:38:37 -0500 Content-Disposition: inline In-Reply-To: <20140102171930.GD27806@cbox> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jan 02, 2014 at 09:19:30AM -0800, Christoffer Dall wrote: > > > How is this going to be used here? The compat ptr stuff in the kernel > > > deals with user space pointer iirc, but I'm not an expert on the > > > details. Does typedef'ing a pointer to a u32 in generic code work on a > > > 64-bit platform? > > > > This is necessary to eliminate compiler warnings when casting 64-bit > > pointers to u32s. > > > > ah, ok, a comment to that effect would be nice for us neandertals still > mostly stuck in the 32-bit worlds. OK > > You should take a look, as they're not verbatim - although almost. I can't > > recall where I might have diverged, I just know I didn't copy+paste :-) > > > > Wonderful, I'll take a look :) Thanks!!