From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH 9/9] arm: initial drop Date: Thu, 2 Jan 2014 11:17:51 -0800 Message-ID: <20140102191751.GK27806@cbox> References: <1386175377-23086-1-git-send-email-drjones@redhat.com> <1386175377-23086-10-git-send-email-drjones@redhat.com> <20131229063135.GH13601@cbox> <20140102165425.GG9725@hawk.usersys.redhat.com> <20140102174439.GH27806@cbox> <20140102185026.GO9725@hawk.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org To: Andrew Jones Return-path: Received: from mail-pb0-f54.google.com ([209.85.160.54]:48876 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbaABTRd (ORCPT ); Thu, 2 Jan 2014 14:17:33 -0500 Received: by mail-pb0-f54.google.com with SMTP id un15so14917964pbc.27 for ; Thu, 02 Jan 2014 11:17:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140102185026.GO9725@hawk.usersys.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jan 02, 2014 at 07:50:27PM +0100, Andrew Jones wrote: > On Thu, Jan 02, 2014 at 09:44:39AM -0800, Christoffer Dall wrote: > > > My cross-compiler was generating broken code with anything less. I > > > haven't checked later compilers yet to see if it's fixed or not. > > > > > > > which GCC version? > > $ arm-linux-gnu-gcc -v > Using built-in specs. > COLLECT_GCC=arm-linux-gnu-gcc > COLLECT_LTO_WRAPPER=/usr/libexec/gcc/arm-linux-gnueabi/4.8.1/lto-wrapper > Target: arm-linux-gnueabi > Configured with: ../gcc-4.8.1-20130717/configure --bindir=/usr/bin > --build=x86_64-redhat-linux-gnu --datadir=/usr/share > --disable-decimal-float --disable-dependency-tracking --disable-gold > --disable-libgomp --disable-libmudflap --disable-libquadmath > --disable-libssp --disable-nls --disable-plugin --disable-shared > --disable-silent-rules --disable-sjlj-exceptions --disable-threads > --enable-checking= --enable-gnu-unique-object --enable-initfini-array > --enable-languages=c --enable-linker-build-id --enable-nls > --enable-obsolete --enable-targets=all --exec-prefix=/usr > --host=x86_64-redhat-linux-gnu --includedir=/usr/include > --infodir=/usr/share/info --libexecdir=/usr/libexec --localstatedir=/var > --mandir=/usr/share/man --prefix=/usr --program-prefix=arm-linux-gnu- > --sbindir=/usr/sbin --sharedstatedir=/var/lib --sysconfdir=/etc > --target=arm-linux-gnueabi > --with-bugurl=http://bugzilla.redhat.com/bugzilla/ > --with-linker-hash-style=gnu --with-newlib --with-system-libunwind > --with-system-zlib --without-headers > --with-isl=/builddir/build/BUILD/gcc-4.8.1-20130717/isl-install > --with-cloog=/builddir/build/BUILD/gcc-4.8.1-20130717/cloog-install > Thread model: single > gcc version 4.8.1 20130717 (Red Hat 4.8.1-5) (GCC) > > > > > I was expecting to see a __raw_... IO accessor definitions for ARM here, > > > > specifically so we avoid the register-writeback versions that are not > > > > supported on ARM. > > > > > > > > See arch/arm/include/asm/io.h in the kernel. > > > > > > k, I'll grab them, but they'll go in lib/arm/io.h. I think I'll drop > > > these lib/test_util.* in v3, so far they're fairly useless cruft. We > > > can bring them back if they have enough purpose later. > > > > > > > I already did that for my WIP, see commit > > 680054064db4dd710991f064a88a12012944d376 in: > > > > https://github.com/columbia/kvm-unit-tests.git > > I'll fetch your tree and start going through it tomorrow. Thanks for > jumping in!! > Sure, if you fix anything in your existing series, I'll be happy to rebase my patches and take a pass at squashing some of them and such so we can get them out as an RFC. -Christoffer