From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH kvm-next 2/2] kvm: remove dead code Date: Tue, 7 Jan 2014 14:14:01 +0100 Message-ID: <20140107141401.753a8630@gondolin> References: <20131229121229.19a97822@nehalam.linuxnetplumber.net> <20131229121308.58f2a077@nehalam.linuxnetplumber.net> <20131230073715.GB6244@minantech.com> <20131230142720.2802b3b1@nehalam.linuxnetplumber.net> <52C2E050.4060302@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , Gleb Natapov , kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:35040 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbaAGNOS (ORCPT ); Tue, 7 Jan 2014 08:14:18 -0500 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 7 Jan 2014 13:14:16 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 0820517D805F for ; Tue, 7 Jan 2014 13:14:21 +0000 (GMT) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s07DE0xK54067322 for ; Tue, 7 Jan 2014 13:14:00 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s07DEBGD025756 for ; Tue, 7 Jan 2014 06:14:12 -0700 In-Reply-To: <52C2E050.4060302@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 31 Dec 2013 16:18:40 +0100 Paolo Bonzini wrote: > Il 30/12/2013 23:27, Stephen Hemminger ha scritto: > >> > It was added recently by Cornelia (copied) with intention to be used in s390 > >> > code. I assume the intention is still there. > > The normal process is that the code is added in one patch just > > before the code that uses it. Rather than the "if we build it they will come" > > philosophy. > > I'm fairly sure that was not the intention; rather, "we built it but we > haven't sent a pull request for whatever reason". Actually, the intention was "let read offer the same interfaces as write". I currently don't see any usage of the read interface from my side; if you prefer to remove it, I won't object.