From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7 Date: Fri, 31 Jan 2014 13:17:53 -0200 Message-ID: <20140131151753.GY2221@otherpad.lan.raisama.net> References: <1391111339-6958-1-git-send-email-ehabkost@redhat.com> <20140131154853.34c41154@thinkpad> <52EBB82F.7020001@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Igor Mammedov , qemu-devel@nongnu.org, kvm@vger.kernel.org, libvir-list@redhat.com, Jiri Denemark , Andreas =?iso-8859-1?Q?F=E4rber?= To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56661 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932462AbaAaPR6 (ORCPT ); Fri, 31 Jan 2014 10:17:58 -0500 Content-Disposition: inline In-Reply-To: <52EBB82F.7020001@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jan 31, 2014 at 03:50:23PM +0100, Paolo Bonzini wrote: > Il 31/01/2014 15:48, Igor Mammedov ha scritto: > >that's abusing of object-add interface and due to recent changes, object-add > >won't accept arbitrary objects. > > I hope that sooner or later device hotplug will be doable with > object-add too. But yes, in the meanwhile device_add could work, > and this patch series is in the right direction anyway. In that case, what is holding us from setting cannot_instantiate_with_device_add_yet on TYPE_X86_CPU? I don't think we can recommend using "-device" for CPUs just yet, but we would need to allow it in case object-add doesn't work. (But I liked the fact that object-add worked and (it looks like) it didn't run realize(). All libvirt needs is to be able to create the object and get instance_init() run, no need for realize() to run.) I still need to read the reasoning behind the object-add changes. But is there some chance we could allow object-add to work for TYPE_X86_CPU subclasses, to avoid the device_add/cannot_instantiate_with_device_add_yet issues? -- Eduardo