From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH 05/17] add 'make cscope' support Date: Sat, 1 Feb 2014 18:22:58 -0800 Message-ID: <20140202022258.GO3570@cbox> References: <1390321323-1855-1-git-send-email-drjones@redhat.com> <1390321323-1855-6-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org To: Andrew Jones Return-path: Received: from mail-pa0-f48.google.com ([209.85.220.48]:43638 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbaBBCWz (ORCPT ); Sat, 1 Feb 2014 21:22:55 -0500 Received: by mail-pa0-f48.google.com with SMTP id kx10so5848196pab.35 for ; Sat, 01 Feb 2014 18:22:54 -0800 (PST) Content-Disposition: inline In-Reply-To: <1390321323-1855-6-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jan 21, 2014 at 05:21:51PM +0100, Andrew Jones wrote: > Add a Makefile target to quickly generate arch-specific cscope > for kvm-unit-tests. Assumes a mostly flat directory structure, > i.e. uses '-maxdepth 1' in the file search. > > Signed-off-by: Andrew Jones > --- > Makefile | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index fa95d66386d49..283655957f39f 100644 > --- a/Makefile > +++ b/Makefile > @@ -3,7 +3,7 @@ include config.mak > > DESTDIR := $(PREFIX)/share/qemu/tests > > -.PHONY: arch_clean clean > +.PHONY: arch_clean clean cscope > > #make sure env CFLAGS variable is not used > CFLAGS = > @@ -52,3 +52,10 @@ install: > > clean: arch_clean > $(RM) lib/.*.d $(libcflat) $(cflatobjs) > + > +cscope: common_dirs = lib > +cscope: > + rm -f ./cscope.* > + find $(TEST_DIR) lib/$(TEST_DIR) $(common_dirs) -maxdepth 1 \ > + -name "*.[chsS]" -print | sed 's,^\./,,' > ./cscope.files shouldn't you use single quotes for the -name pattern to avoid any substitutions here? > + cscope -bk > -- > 1.8.1.4 > Otherwise: Acked-by: Christoffer Dall