Re: [PATCH 13/17] arm: initial drop

[Christoffer Dall <christoffer.dall@linaro.org>]

On Tue, Jan 21, 2014 at 05:21:59PM +0100, Andrew Jones wrote:
> This is the initial arm test framework and a first simple test that
> checks some bootinfo. kvm isn't needed to run this test. This patch
> also adds a common build environment variable, $QEMU_BIN, which
> allows makefiles to call on qemu when needed.
> 
> Try it out with
>   yum install gcc-arm-linux-gnu dtc
>   export QEMU=[qemu with mach-virt and virtio-testdev]
>   ./configure --cross-prefix=arm-linux-gnu- --arch=arm
>   make
>   ./run_tests.sh
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> 
> ---

[...]

> diff --git a/lib/arm/setup.c b/lib/arm/setup.c
> new file mode 100644
> index 0000000000000..1db249a1eb94c
> --- /dev/null
> +++ b/lib/arm/setup.c
> @@ -0,0 +1,46 @@
> +#include "libcflat.h"
> +#include "devicetree.h"
> +#include "arm/sysinfo.h"
> +#include "heap.h"
> +
> +extern void io_init(void);
> +extern void setup_args(char *args);
> +
> +extern unsigned long stacktop;
> +
> +void *mem_start;
> +size_t mem_size;
> +char *bootargs;

const char *bootargs?

> +
> +static void read_bootinfo(const void *fdt)
> +{
> +	int ret;
> +

[...]

Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>