From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH 16/17] arm: add useful headers from the linux kernel
Date: Mon, 3 Feb 2014 09:38:28 -0800
Message-ID: <20140203173828.GG4167@cbox>
References: <1390321323-1855-1-git-send-email-drjones@redhat.com>
 <1390321323-1855-17-git-send-email-drjones@redhat.com>
 <20140202022905.GY3570@cbox>
 <20140203164607.GH6832@hawk.usersys.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pa0-f47.google.com ([209.85.220.47]:51806 "EHLO
	mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752114AbaBCRiW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 3 Feb 2014 12:38:22 -0500
Received: by mail-pa0-f47.google.com with SMTP id kp14so7353485pab.20
        for <kvm@vger.kernel.org>; Mon, 03 Feb 2014 09:38:22 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140203164607.GH6832@hawk.usersys.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Feb 03, 2014 at 05:46:08PM +0100, Andrew Jones wrote:
> On Sat, Feb 01, 2014 at 06:29:05PM -0800, Christoffer Dall wrote:
> > On Tue, Jan 21, 2014 at 05:22:02PM +0100, Andrew Jones wrote:
> > > We're going to need PSR bit defines and pt_regs. We'll also need
> > > pt_regs offsets in assembly code. This patch adapts the linux
> > > kernel's ptrace.h and asm-offsets to this framework. Even though
> > > lib/arm/asm-offsets.h is a generated file, we still commit it,
> > > as it's unlikely to change. Also adapt cp15.h from the kernel,
> > > since we'll need bit defines from there too.
> > > 
> > > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > > ---
> > 
> > [...]
> > 
> > > +
> > > +asm-offsets: scripts/arm/asm-offsets.flat
> > > +	$(QEMU) -device virtio-testdev -display none -serial stdio \
> > > +		-M virt -cpu $(PROCESSOR) \
> > > +		-kernel $^ > lib/arm/asm-offsets.h || true
> > 
> > I still disagree with this requirement to have the correct version of
> > qemu on the build machine.
> 
> Ah sorry, I forgot about this one. I'll steal more from the kernel
> on the asm-offsets generation to improve this for v4.
> 
Cool, thanks!