From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v3 07/11] ARM: KVM: fix handling of trapped 64bit coprocessor accesses Date: Thu, 6 Feb 2014 10:49:58 +0000 Message-ID: <20140206104958.GD29446@arm.com> References: <1391630151-7875-1-git-send-email-marc.zyngier@arm.com> <1391630151-7875-8-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Christoffer Dall To: Marc Zyngier Return-path: Received: from fw-tnat.austin.arm.com ([217.140.110.23]:53409 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754289AbaBFKug (ORCPT ); Thu, 6 Feb 2014 05:50:36 -0500 Content-Disposition: inline In-Reply-To: <1391630151-7875-8-git-send-email-marc.zyngier@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Feb 05, 2014 at 07:55:47PM +0000, Marc Zyngier wrote: > Commit 240e99cbd00a (ARM: KVM: Fix 64-bit coprocessor handling) > changed the way we match the 64bit coprocessor access from > user space, but didn't update the trap handler for the same > set of registers. > > The effect is that a trapped 64bit access is never matched, leading > to a fault being injected into the guest. This went unnoticed as we > didn't really trap any 64bit register so far. > > Placing the CRm field of the access into the CRn field of the matching > structure fixes the problem. Also update the debug feature to emit the > expected string in case of failing match. > > Signed-off-by: Marc Zyngier > Reviewed-by: Christoffer Dall Acked-by: Catalin Marinas