From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v3 08/11] ARM: KVM: fix ordering of 64bit coprocessor accesses Date: Thu, 6 Feb 2014 10:50:23 +0000 Message-ID: <20140206105022.GE29446@arm.com> References: <1391630151-7875-1-git-send-email-marc.zyngier@arm.com> <1391630151-7875-9-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Christoffer Dall To: Marc Zyngier Return-path: Received: from fw-tnat.austin.arm.com ([217.140.110.23]:53518 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755706AbaBFKvA (ORCPT ); Thu, 6 Feb 2014 05:51:00 -0500 Content-Disposition: inline In-Reply-To: <1391630151-7875-9-git-send-email-marc.zyngier@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Feb 05, 2014 at 07:55:48PM +0000, Marc Zyngier wrote: > Commit 240e99cbd00a (ARM: KVM: Fix 64-bit coprocessor handling) > added an ordering dependency for the 64bit registers. > > The order described is: CRn, CRm, Op1, Op2, 64bit-first. > > Unfortunately, the implementation is: CRn, 64bit-first, CRm... > > Move the 64bit test to be last in order to match the documentation. > > Signed-off-by: Marc Zyngier > Reviewed-by: Christoffer Dall Acked-by: Catalin Marinas