From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v4 04/12] ARM: KVM: introduce kvm_p*d_addr_end Date: Tue, 18 Feb 2014 15:41:02 +0000 Message-ID: <20140218154101.GC904@localhost> References: <1392737253-10480-1-git-send-email-marc.zyngier@arm.com> <1392737253-10480-5-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Christoffer Dall To: Marc Zyngier Return-path: Received: from fw-tnat.austin.arm.com ([217.140.110.23]:27724 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932131AbaBRPlH (ORCPT ); Tue, 18 Feb 2014 10:41:07 -0500 Content-Disposition: inline In-Reply-To: <1392737253-10480-5-git-send-email-marc.zyngier@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Feb 18, 2014 at 03:27:25PM +0000, Marc Zyngier wrote: > The use of p*d_addr_end with stage-2 translation is slightly dodgy, > as the IPA is 40bits, while all the p*d_addr_end helpers are > taking an unsigned long (arm64 is fine with that as unligned long > is 64bit). > > The fix is to introduce 64bit clean versions of the same helpers, > and use them in the stage-2 page table code. > > Signed-off-by: Marc Zyngier Acked-by: Catalin Marinas