kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: file_ram_alloc: unify mem-path,mem-prealloc error handling
Date: Thu, 27 Feb 2014 22:05:57 -0300	[thread overview]
Message-ID: <20140228010557.GA12337@amt.cnet> (raw)
In-Reply-To: <530F8442.7090007@redhat.com>

On Thu, Feb 27, 2014 at 07:30:26PM +0100, Paolo Bonzini wrote:
> Il 04/02/2014 19:41, Marcelo Tosatti ha scritto:
> >
> >-mem-prealloc asks to preallocate memory residing on -mem-path path.
> >
> >Currently QEMU exits in case:
> >
> >- Memory file has been created but allocation via explicit write
> >fails.
> >
> >And it fallbacks to malloc in case:
> >- Querying huge page size fails.
> >- Lack of sync MMU support.
> >- Open fails.
> >- mmap fails.
> >
> >Have the same behaviour for all cases: fail in case -mem-path and
> >-mem-prealloc are specified for regions where the requested size is
> >suitable for hugepages.
> >
> >Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> Once we introduce memdev, I believe -mem-path should always exit,
> and never fall back to malloc/MAP_ANON.

Agree.


  reply	other threads:[~2014-02-28 14:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 18:41 file_ram_alloc: unify mem-path,mem-prealloc error handling Marcelo Tosatti
2014-02-04 18:43 ` Marcelo Tosatti
2014-02-07  8:39 ` Paolo Bonzini
2014-02-27 18:30 ` Paolo Bonzini
2014-02-28  1:05   ` Marcelo Tosatti [this message]
2014-02-28 12:55   ` [Qemu-devel] file_ram_alloc: unify mem-path, mem-prealloc " Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140228010557.GA12337@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).