From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
alex.williamson@redhat.com, mtosatti@redhat.com, gleb@kernel.org,
jan.kiszka@siemens.com
Subject: Re: [PATCH 0/7] KVM: x86: Let the guest write to multiple debug registers with one vmexit
Date: Mon, 10 Mar 2014 13:23:43 +0100 [thread overview]
Message-ID: <20140310122342.GA16392@potion.brq.redhat.com> (raw)
In-Reply-To: <1394192571-11056-1-git-send-email-pbonzini@redhat.com>
2014-03-07 12:42+0100, Paolo Bonzini:
> Alex Williamson reported that a Windows game does something weird that
> makes the guest save and restore debug registers on each context switch.
> This cause several hundred thousands vmexits per second, and basically
> cuts performance in half when running under KVM.
>
> However, when not running in guest-debug mode, the guest controls the
> debug registers and having to take an exit for each DR access is a waste
> of time. We just need one vmexit to load any stale values of DR0-DR6,
> and then we can let the guest run freely. On the next vmexit (whatever
> the reason) we will read out whatever changes the guest made to the
> debug registers.
>
> Tested with x86/debug.flat on both Intel and AMD, both direct and
> nested virtualization.
>
> Changes from RFC: changed get_dr7 callback to sync_dirty_debug_regs,
> new patches 5-7.
>
> Paolo Bonzini (7):
> KVM: vmx: we do rely on loading DR7 on entry
> KVM: x86: change vcpu->arch.switch_db_regs to a bit mask
> KVM: x86: Allow the guest to run with dirty debug registers
> KVM: vmx: Allow the guest to run with dirty debug registers
> KVM: nVMX: Allow nested guests to run with dirty debug registers
> KVM: svm: set/clear all DR intercepts in one swoop
> KVM: svm: Allow the guest to run with dirty debug registers
All patches,
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
This series is good even without vmcs_{set,clr}_bits().
(There is enough of them already to warrant a cleanup patch.)
>
> arch/x86/include/asm/kvm_host.h | 8 ++++-
> arch/x86/kvm/svm.c | 68 ++++++++++++++++++++++++++++-------------
> arch/x86/kvm/vmx.c | 43 ++++++++++++++++++++++++--
> arch/x86/kvm/x86.c | 20 +++++++++++-
> 4 files changed, 114 insertions(+), 25 deletions(-)
>
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2014-03-10 12:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 11:42 [PATCH 0/7] KVM: x86: Let the guest write to multiple debug registers with one vmexit Paolo Bonzini
2014-03-07 11:42 ` [PATCH 1/7] KVM: vmx: we do rely on loading DR7 on entry Paolo Bonzini
2014-03-07 11:42 ` [PATCH 2/7] KVM: x86: change vcpu->arch.switch_db_regs to a bit mask Paolo Bonzini
2014-03-07 11:42 ` [PATCH 3/7] KVM: x86: Allow the guest to run with dirty debug registers Paolo Bonzini
2014-03-09 18:28 ` Radim Krčmář
2014-03-09 20:07 ` Paolo Bonzini
2014-03-10 12:11 ` Radim Krčmář
2014-03-07 11:42 ` [PATCH 4/7] KVM: vmx: " Paolo Bonzini
2014-03-09 18:26 ` Radim Krčmář
2014-03-09 20:12 ` Paolo Bonzini
2014-03-10 12:17 ` Radim Krčmář
2014-03-10 12:24 ` Paolo Bonzini
2014-03-07 11:42 ` [PATCH 5/7] KVM: nVMX: Allow nested guests " Paolo Bonzini
2014-03-07 11:42 ` [PATCH 6/7] KVM: svm: set/clear all DR intercepts in one swoop Paolo Bonzini
2014-03-07 11:42 ` [PATCH 7/7] KVM: svm: Allow the guest to run with dirty debug registers Paolo Bonzini
2014-03-09 8:11 ` [PATCH 0/7] KVM: x86: Let the guest write to multiple debug registers with one vmexit Jan Kiszka
2014-03-09 8:15 ` Jan Kiszka
2014-03-09 8:31 ` Paolo Bonzini
2014-03-10 12:23 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310122342.GA16392@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox