From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [PATCH v2 4/7] trace: Make UPROBES depend on PERF_EVENTS Date: Mon, 10 Mar 2014 08:03:09 -0700 Message-ID: <20140310150308.GA9316@leaf> References: <32f5e0a3b421b615be3af24b0319afff1a385403.1394418994.git.josh@joshtriplett.org> <20140310142129.GA21735@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Suravee Suthikulpanit , Frederic Weisbecker , David Herrmann , Stephane Eranian , Paul Gortmaker , Paul Mackerras , "H. Peter Anvin" , Thomas Gleixner , Andi Kleen , x86@kernel.org, Ingo Molnar , oprofile-list@lists.sf.net, Mel Gorman , Arnaldo Carvalho de Melo , Borislav Petkov , Dave Young , Peter Zijlstra , Gleb Natapov , Steven Rostedt , Bin Gao , Matt Fleming , Jacob Shin , linux-kernel@vger.kernel.org, Torsten Kaiser Return-path: Content-Disposition: inline In-Reply-To: <20140310142129.GA21735@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: oprofile-list-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org On Mon, Mar 10, 2014 at 03:21:29PM +0100, Oleg Nesterov wrote: > On 03/09, Josh Triplett wrote: > > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > > index 015f85a..8639819 100644 > > --- a/kernel/trace/Kconfig > > +++ b/kernel/trace/Kconfig > > @@ -424,6 +424,7 @@ config UPROBE_EVENT > > bool "Enable uprobes-based dynamic events" > > depends on ARCH_SUPPORTS_UPROBES > > depends on MMU > > + depends on PERF_EVENTS > > Can't we delay this change? This conflicts with > > [PATCH v7 01/15] uprobes: Kconfig dependency fix > http://marc.info/?l=linux-kernel&m=139422332915701 That doesn't conflict; they both make exactly the same change, and they should trivially merge. - Josh Triplett ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech