From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM Date: Thu, 10 Apr 2014 17:01:49 -0300 Message-ID: <20140410200149.GA26092@amt.cnet> References: <1396345596-25682-1-git-send-email-feng.wu@intel.com> <533D904E.30801@redhat.com> <533E5EE3.4030708@redhat.com> <53445E30.6010809@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Wu, Feng" , "gleb@redhat.com" , "hpa@zytor.com" , "kvm@vger.kernel.org" To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14940 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759129AbaDJUQ0 (ORCPT ); Thu, 10 Apr 2014 16:16:26 -0400 Content-Disposition: inline In-Reply-To: <53445E30.6010809@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Apr 08, 2014 at 04:38:08PM -0400, Paolo Bonzini wrote: > Il 07/04/2014 21:06, Wu, Feng ha scritto: > >>> Even though the tests do not cover the CPL=3/implicit access case, the > >>> logic to compute PFERR_RSVD_MASK dynamically is already covered by AC=1. > >>> So I'm quite happy with the coverage. Series is > >>> > >>> Reviewed-by: Paolo Bonzini ] > >Thanks very much for your review on this. > >BTW: Since 3.15 merge window is still open, I am wondering whether there is > >any possibility to make SMAP into 3.15 with another pull request. > > > > This is up to Marcelo who is currently managing the KVM tree. > > Paolo The merge window is for patches which have been tested in queue/next for sometime. This patch has received no testing other than the developer testing. Lack of implicit supervisor mode by instructions such as "Examples of such implicit..." in section 9.3.2, in KVM's emulator, makes the feature incomplete, does it not ? (would have to signal those accesses as supervisor ones).