From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ronen Hod <rhod@redhat.com>
Cc: vrozenfe@redhat.com, pbonzini@redhat.com, kvm@vger.kernel.org
Subject: [PATCH RFC untested] kvm/x86: implement hv EOI assist
Date: Sun, 13 Apr 2014 16:10:22 +0300 [thread overview]
Message-ID: <20140413131021.GA19125@redhat.com> (raw)
It seems that it's easy to implement the EOI assist
on top of the PV EOI feature: simply convert the
page address to the format expected by PV EOI.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Warning: untested! As I'll be off-line for a couple of days,
sending this out for early review.
Review/comments/flames/testing reports welcome.
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 8ae1ff5..d84d750fc 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1890,6 +1890,8 @@ static int set_msr_hyperv(struct kvm_vcpu *vcpu, u32 msr, u64 data)
if (!(data & HV_X64_MSR_APIC_ASSIST_PAGE_ENABLE)) {
vcpu->arch.hv_vapic = data;
+ if (kvm_lapic_enable_pv_eoi(vcpu, 0))
+ return 1;
break;
}
gfn = data >> HV_X64_MSR_APIC_ASSIST_PAGE_ADDRESS_SHIFT;
@@ -1900,6 +1902,8 @@ static int set_msr_hyperv(struct kvm_vcpu *vcpu, u32 msr, u64 data)
return 1;
vcpu->arch.hv_vapic = data;
mark_page_dirty(vcpu->kvm, gfn);
+ if (kvm_lapic_enable_pv_eoi(vcpu, gfn_to_gpa(gfn) | KVM_MSR_ENABLED))
+ return 1;
break;
}
case HV_X64_MSR_EOI:
next reply other threads:[~2014-04-13 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 13:10 Michael S. Tsirkin [this message]
2014-04-21 21:40 ` [PATCH RFC untested] kvm/x86: implement hv EOI assist Marcelo Tosatti
2014-04-22 9:11 ` Michael S. Tsirkin
2014-04-22 19:26 ` Marcelo Tosatti
2014-04-22 22:12 ` Michael S. Tsirkin
2014-04-23 1:57 ` Marcelo Tosatti
2014-04-23 5:52 ` Michael S. Tsirkin
2014-04-23 18:30 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140413131021.GA19125@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rhod@redhat.com \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).