From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist Date: Mon, 21 Apr 2014 18:40:17 -0300 Message-ID: <20140421214017.GB5186@amt.cnet> References: <20140413131021.GA19125@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ronen Hod , vrozenfe@redhat.com, pbonzini@redhat.com, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29866 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752896AbaDUVke (ORCPT ); Mon, 21 Apr 2014 17:40:34 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3LLeV0A012965 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Apr 2014 17:40:34 -0400 Content-Disposition: inline In-Reply-To: <20140413131021.GA19125@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Apr 13, 2014 at 04:10:22PM +0300, Michael S. Tsirkin wrote: > It seems that it's easy to implement the EOI assist > on top of the PV EOI feature: simply convert the > page address to the format expected by PV EOI. > > Signed-off-by: Michael S. Tsirkin Looks alright except: - There is no handling of PV EOI data to be performed at HV_X64_MSR_EOI write path? - Migration fails with PV-EOI not enabled in CPUID ? (perhaps could require it for PV-EOI over HV-APIC-ASSIST). - MS docs mention "No EOI required" is set only if interrupt injected is edge triggered.