From: Marcelo Tosatti <mtosatti@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
"Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed
Date: Tue, 22 Apr 2014 18:27:59 -0300 [thread overview]
Message-ID: <20140422212759.GB28571@amt.cnet> (raw)
In-Reply-To: <20140422203807.GJ3363@otherpad.lan.raisama.net>
On Tue, Apr 22, 2014 at 05:38:07PM -0300, Eduardo Habkost wrote:
> On Tue, Apr 22, 2014 at 04:10:44PM -0300, Marcelo Tosatti wrote:
> > Invariant TSC documentation mentions that "invariant TSC will run at a
> > constant rate in all ACPI P-, C-. and T-states".
> >
> > This is not the case if migration to a host with different TSC frequency
> > is allowed, or if savevm is performed. So block migration/savevm.
> >
> > Also do not expose invariant tsc flag by default.
>
> What do you mean "do not expose invtsc by default", exactly? It is
> already not exposed by default because the default CPU model is qemu64
> and qemu64 doesn't have it enabled.
Should be "do not expose invtsc by default with -cpu host".
Since it blocks migration, i considered it a special flag that should
be set when user is aware that migration is going to be blocked.
Makes sense?
next prev parent reply other threads:[~2014-04-22 21:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 19:10 [patch 0/2] expose invariant tsc flag for kvm guests Marcelo Tosatti
2014-04-22 19:10 ` [patch 1/2] target-i386: support "invariant tsc" flag Marcelo Tosatti
2014-04-23 0:26 ` Paolo Bonzini
2014-04-23 1:11 ` Eduardo Habkost
2014-04-22 19:10 ` [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed Marcelo Tosatti
2014-04-22 19:28 ` Marcelo Tosatti
2014-04-22 20:38 ` Eduardo Habkost
2014-04-22 21:27 ` Marcelo Tosatti [this message]
2014-04-23 1:14 ` Eduardo Habkost
2014-04-24 20:42 ` Paolo Bonzini
2014-04-24 20:57 ` Eduardo Habkost
2014-04-24 22:57 ` Paolo Bonzini
2014-04-24 23:18 ` Eduardo Habkost
2014-04-25 21:08 ` Paolo Bonzini
2014-04-28 15:46 ` Eduardo Habkost
2014-04-28 19:06 ` Paolo Bonzini
2014-04-28 19:23 ` Eduardo Habkost
2014-04-29 6:22 ` Paolo Bonzini
2014-04-29 14:29 ` Eduardo Habkost
2014-04-23 18:20 ` [patch 0/2] expose invariant tsc flag for kvm guests (v2) Marcelo Tosatti
2014-04-23 18:20 ` [patch 1/2] target-i386: support "invariant tsc" flag Marcelo Tosatti
2014-04-23 19:04 ` Eduardo Habkost
2014-04-23 18:20 ` [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed Marcelo Tosatti
2014-04-23 19:09 ` Eduardo Habkost
2014-04-23 21:04 ` target-i386: block migration and savevm if invariant tsc is exposed (v3) Marcelo Tosatti
2014-04-24 19:21 ` Eduardo Habkost
2014-04-24 21:32 ` Marcelo Tosatti
2014-04-25 20:38 ` Eduardo Habkost
2014-04-25 22:47 ` [PATCH] savevm: check vmsd for migratability status Marcelo Tosatti
2014-04-28 20:36 ` Eduardo Habkost
2014-04-30 0:39 ` [PATCH] savevm: check vmsd for migratability status (v2) Marcelo Tosatti
2014-04-30 15:47 ` [Qemu-devel] " Eduardo Habkost
2014-04-25 22:47 ` target-i386: block migration and savevm if invariant tsc is exposed (v3) Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422212759.GB28571@amt.cnet \
--to=mtosatti@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox