public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Igor Mammedov" <imammedo@redhat.com>
Subject: [PATCH] savevm: check vmsd for migratability status (v2)
Date: Tue, 29 Apr 2014 21:39:03 -0300	[thread overview]
Message-ID: <20140430003903.GA23414@amt.cnet> (raw)
In-Reply-To: <20140428203624.GB3363@otherpad.lan.raisama.net>

Check vmsd for unmigratable field, allowing migratibility status
to be modified after vmstate_register.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

diff --git a/savevm.c b/savevm.c
index da8aa24..c578e42 100644
--- a/savevm.c
+++ b/savevm.c
@@ -232,7 +232,6 @@ typedef struct SaveStateEntry {
     const VMStateDescription *vmsd;
     void *opaque;
     CompatEntry *compat;
-    int no_migrate;
     int is_ram;
 } SaveStateEntry;
 
@@ -292,7 +291,6 @@ int register_savevm_live(DeviceState *dev,
     se->ops = ops;
     se->opaque = opaque;
     se->vmsd = NULL;
-    se->no_migrate = 0;
     /* if this is a live_savem then set is_ram */
     if (ops->save_live_setup != NULL) {
         se->is_ram = 1;
@@ -383,7 +381,6 @@ int vmstate_register_with_alias_id(DeviceState *dev, int instance_id,
     se->opaque = opaque;
     se->vmsd = vmsd;
     se->alias_id = alias_id;
-    se->no_migrate = vmsd->unmigratable;
 
     if (dev) {
         char *id = qdev_get_dev_path(dev);
@@ -452,7 +449,7 @@ bool qemu_savevm_state_blocked(Error **errp)
     SaveStateEntry *se;
 
     QTAILQ_FOREACH(se, &savevm_handlers, entry) {
-        if (se->no_migrate) {
+        if (se->vmsd && se->vmsd->unmigratable) {
             error_setg(errp, "State blocked by non-migratable device '%s'",
                        se->idstr);
             return true;

  reply	other threads:[~2014-04-30  0:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 19:10 [patch 0/2] expose invariant tsc flag for kvm guests Marcelo Tosatti
2014-04-22 19:10 ` [patch 1/2] target-i386: support "invariant tsc" flag Marcelo Tosatti
2014-04-23  0:26   ` Paolo Bonzini
2014-04-23  1:11     ` Eduardo Habkost
2014-04-22 19:10 ` [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed Marcelo Tosatti
2014-04-22 19:28   ` Marcelo Tosatti
2014-04-22 20:38   ` Eduardo Habkost
2014-04-22 21:27     ` Marcelo Tosatti
2014-04-23  1:14       ` Eduardo Habkost
2014-04-24 20:42         ` Paolo Bonzini
2014-04-24 20:57           ` Eduardo Habkost
2014-04-24 22:57             ` Paolo Bonzini
2014-04-24 23:18               ` Eduardo Habkost
2014-04-25 21:08                 ` Paolo Bonzini
2014-04-28 15:46                   ` Eduardo Habkost
2014-04-28 19:06                     ` Paolo Bonzini
2014-04-28 19:23                       ` Eduardo Habkost
2014-04-29  6:22                         ` Paolo Bonzini
2014-04-29 14:29                           ` Eduardo Habkost
2014-04-23 18:20 ` [patch 0/2] expose invariant tsc flag for kvm guests (v2) Marcelo Tosatti
2014-04-23 18:20   ` [patch 1/2] target-i386: support "invariant tsc" flag Marcelo Tosatti
2014-04-23 19:04     ` Eduardo Habkost
2014-04-23 18:20   ` [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed Marcelo Tosatti
2014-04-23 19:09     ` Eduardo Habkost
2014-04-23 21:04       ` target-i386: block migration and savevm if invariant tsc is exposed (v3) Marcelo Tosatti
2014-04-24 19:21         ` Eduardo Habkost
2014-04-24 21:32           ` Marcelo Tosatti
2014-04-25 20:38             ` Eduardo Habkost
2014-04-25 22:47               ` [PATCH] savevm: check vmsd for migratability status Marcelo Tosatti
2014-04-28 20:36                 ` Eduardo Habkost
2014-04-30  0:39                   ` Marcelo Tosatti [this message]
2014-04-30 15:47                     ` [Qemu-devel] [PATCH] savevm: check vmsd for migratability status (v2) Eduardo Habkost
2014-04-25 22:47               ` target-i386: block migration and savevm if invariant tsc is exposed (v3) Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140430003903.GA23414@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox