From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] kvmclock: Ensure time in migration never goes backward Date: Wed, 14 May 2014 03:47:28 -0300 Message-ID: <20140514064728.GA6064@amt.cnet> References: <1399297882-3444-1-git-send-email-agraf@suse.de> <20140508013325.GA5474@amt.cnet> <536B3079.7060109@suse.de> <20140509022831.GB21213@amt.cnet> <536CC1BC.2000302@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Graf , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48312 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751067AbaENGrz (ORCPT ); Wed, 14 May 2014 02:47:55 -0400 Content-Disposition: inline In-Reply-To: <536CC1BC.2000302@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, May 09, 2014 at 01:53:32PM +0200, Paolo Bonzini wrote: > Il 09/05/2014 04:28, Marcelo Tosatti ha scritto: > >Alex, > > > >Unability to upgrade systems is not an excuse to fix the bug in the > >wrong place. > > It may be an excuse to fix the bug in both places though. > > Paolo Actually, its messy to fix this in kernel, because its necessary to read TSC MSR of a remote vcpu. So it seems more appropriate to do this in QEMU. Sorry for the noise. Alexander, can you resend without the printf? Also checking for "larger than" is not necessary as discussed because it is always true.