From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] kvmclock: Ensure time in migration never goes backward Date: Wed, 14 May 2014 04:26:25 -0300 Message-ID: <20140514072625.GB7042@amt.cnet> References: <1399297882-3444-1-git-send-email-agraf@suse.de> <20140508013325.GA5474@amt.cnet> <536B3079.7060109@suse.de> <20140509022831.GB21213@amt.cnet> <536CC1BC.2000302@redhat.com> <53712E7D.4060308@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1961 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbaENHls (ORCPT ); Wed, 14 May 2014 03:41:48 -0400 Content-Disposition: inline In-Reply-To: <53712E7D.4060308@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 12, 2014 at 10:26:37PM +0200, Alexander Graf wrote: > > On 09.05.14 13:53, Paolo Bonzini wrote: > >Il 09/05/2014 04:28, Marcelo Tosatti ha scritto: > >>Alex, > >> > >>Unability to upgrade systems is not an excuse to fix the bug in the > >>wrong place. > > > >It may be an excuse to fix the bug in both places though. > > The bug in the kernel should be fixed differently though to ensure > we don't go backwards in time during runtime, no? That can't happen because we don't ever update it, after "KVM: x86: disable master clock if TSC is reset during suspend".