From: Ralf Baechle <ralf@linux-mips.org>
To: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
Cc: linux-mips@linux-mips.org, David Daney <ddaney.cavm@gmail.com>,
James Hogan <james.hogan@imgtec.com>,
kvm@vger.kernel.org, David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 11/15] MIPS: paravirt: Add pci controller for virtio
Date: Wed, 21 May 2014 15:34:07 +0200 [thread overview]
Message-ID: <20140521133407.GS10287@linux-mips.org> (raw)
In-Reply-To: <1400597236-11352-12-git-send-email-andreas.herrmann@caviumnetworks.com>
On Tue, May 20, 2014 at 04:47:12PM +0200, Andreas Herrmann wrote:
> +
> +union pci_config_address {
> + struct {
> +#ifdef __LITTLE_ENDIAN
> + unsigned register_number : 8; /* 7 .. 0 */
> + unsigned devfn_number : 8; /* 15 .. 8 */
> + unsigned bus_number : 8; /* 23 .. 16 */
> + unsigned reserved : 7; /* 30 .. 24 */
> + unsigned enable_bit : 1; /* 31 */
> +#else
> + unsigned enable_bit : 1; /* 31 */
> + unsigned reserved : 7; /* 30 .. 24 */
> + unsigned bus_number : 8; /* 23 .. 16 */
> + unsigned devfn_number : 8; /* 15 .. 8 */
> + unsigned register_number : 8; /* 7 .. 0 */
> +#endif
For this kind of endianess dependency there is a more elegant way of
defining things in linux-next's <uapi/asm/bitfield.h> like:
#include <uapi/asm/bitfield.h>
...
struct {
__BITFIELD_FIELD(unsigned enable_bit : 1, /* 31 */
__BITFIELD_FIELD(unsigned reserved : 7, /* 30 .. 24 */
__BITFIELD_FIELD(unsigned bus_number : 8, /* 23 .. 16 */
__BITFIELD_FIELD(unsigned devfn_number : 8, /* 15 .. 8 */
__BITFIELD_FIELD(unsigned register_number : 8, /* 7 .. 0 */
)))));
};
No ifdef, no duplication!
Ralf
next prev parent reply other threads:[~2014-05-21 13:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 14:47 [PATCH 00/15] MIPS: Add mips_paravirt Andreas Herrmann
2014-05-20 14:47 ` [PATCH 01/15] MIPS: OCTEON: Enable use of FPU Andreas Herrmann
2014-05-20 14:47 ` [PATCH 02/15] MIPS: Move system level config items from CPU_CAVIUM_OCTEON to CAVIUM_OCTEON_SOC Andreas Herrmann
2014-05-20 14:47 ` [PATCH 03/15] MIPS: OCTEON: Move CAVIUM_OCTEON_CVMSEG_SIZE to CPU_CAVIUM_OCTEON Andreas Herrmann
2014-05-20 22:52 ` James Hogan
2014-05-20 23:23 ` David Daney
2014-05-21 6:22 ` Andreas Herrmann
2014-05-20 14:47 ` [PATCH 04/15] MIPS: Don't use RI/XI with 32-bit kernels on 64-bit CPUs Andreas Herrmann
2014-05-20 14:47 ` [PATCH 05/15] MIPS: Don't build fast TLB refill handler with 32-bit kernels Andreas Herrmann
2014-05-21 9:38 ` James Hogan
2014-05-21 13:04 ` Ralf Baechle
2014-05-21 13:17 ` Andreas Herrmann
2014-05-20 14:47 ` [PATCH 06/15] MIPS: Add minimal support for OCTEON3 to c-r4k.c Andreas Herrmann
2014-05-21 10:04 ` James Hogan
2014-05-21 16:10 ` David Daney
2014-05-21 12:40 ` Ralf Baechle
2014-05-21 21:02 ` Andreas Herrmann
2014-05-22 7:59 ` Ralf Baechle
2014-05-20 14:47 ` [PATCH 07/15] MIPS: Add mips_cpunum() function Andreas Herrmann
2014-05-21 11:10 ` James Hogan
2014-05-22 16:13 ` Andreas Herrmann
2014-05-22 16:15 ` James Hogan
2014-05-20 14:47 ` [PATCH 08/15] MIPS: OCTEON: Add OCTEON3 to __get_cpu_type Andreas Herrmann
2014-05-20 14:47 ` [PATCH 09/15] MIPS: Add functions for hypervisor call Andreas Herrmann
2014-05-21 0:16 ` James Hogan
2014-05-21 7:30 ` Andreas Herrmann
2014-05-20 14:47 ` [PATCH 10/15] MIPS: Add code for new system 'paravirt' Andreas Herrmann
2014-05-21 13:39 ` James Hogan
2014-05-21 16:31 ` David Daney
2014-05-21 16:46 ` James Hogan
2014-05-23 20:31 ` Andreas Herrmann
2014-05-22 16:54 ` Andreas Herrmann
2014-05-23 20:28 ` Andreas Herrmann
2014-05-23 21:47 ` Ralf Baechle
2014-05-20 14:47 ` [PATCH 11/15] MIPS: paravirt: Add pci controller for virtio Andreas Herrmann
2014-05-21 11:42 ` James Hogan
2014-05-22 20:17 ` Andreas Herrmann
2014-05-28 22:10 ` Andreas Herrmann
2014-05-21 13:34 ` Ralf Baechle [this message]
2014-05-20 14:47 ` [PATCH 12/15] MIPS: Enable build for new system 'paravirt' Andreas Herrmann
2014-05-20 14:47 ` [PATCH 13/15] MIPS: Add defconfig for mips_paravirt Andreas Herrmann
2014-05-20 23:14 ` James Hogan
2014-05-21 6:29 ` Andreas Herrmann
2014-05-20 14:47 ` [PATCH 14/15] MIPS: paravirt: Update mips_paravirt_defconfig Andreas Herrmann
2014-05-20 23:17 ` James Hogan
2014-05-21 6:36 ` Andreas Herrmann
2014-05-20 14:47 ` [PATCH 15/15] MIPS: paravirt: Provide _machine_halt function to exit VM on shutdown of guest Andreas Herrmann
2014-05-21 13:44 ` James Hogan
2014-05-28 22:04 ` Andreas Herrmann
2014-05-28 23:18 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521133407.GS10287@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=andreas.herrmann@caviumnetworks.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).