From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] kvm_stat: always display non tracepoint based stats
Date: Wed, 21 May 2014 11:39:18 -0300 [thread overview]
Message-ID: <20140521143918.GA2804@amt.cnet> (raw)
In-Reply-To: <537C9F3B.9090906@redhat.com>
On Wed, May 21, 2014 at 02:42:35PM +0200, Paolo Bonzini wrote:
> Il 21/05/2014 14:27, Marcelo Tosatti ha scritto:
> >On Wed, May 21, 2014 at 12:44:51PM +0200, Paolo Bonzini wrote:
> >>The old stats contain information not available in the tracepoints.
> >>
> >>Inspired by a patch from Marcelo Tosatti.
> >
> >I avoided that because there is overlapping information.
> >
> >Now you report kvm_exit count twice, for example.
>
> What about doing both, i.e. adding the options and the ability to
> choose multiple providers? That is, adding --tracepoint and
> --debugfs options on top of my patch? So if you use --tracepoint
> and tracing is not available, you get an error unlike the current
> behavior, and you can also use --tracepoint --debugfs together.
>
> Paolo
Sounds good to me.
prev parent reply other threads:[~2014-05-21 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 10:44 [PATCH] kvm_stat: always display non tracepoint based stats Paolo Bonzini
2014-05-21 12:27 ` Marcelo Tosatti
2014-05-21 12:42 ` Paolo Bonzini
2014-05-21 14:39 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521143918.GA2804@amt.cnet \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox