From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 06/15] MIPS: Add minimal support for OCTEON3 to c-r4k.c
Date: Thu, 22 May 2014 09:59:34 +0200
Message-ID: <20140522075934.GU10287@linux-mips.org>
References: <1400597236-11352-1-git-send-email-andreas.herrmann@caviumnetworks.com>
 <1400597236-11352-7-git-send-email-andreas.herrmann@caviumnetworks.com>
 <20140521124041.GP10287@linux-mips.org>
 <20140521210212.GH11800@alberich>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-mips@linux-mips.org, David Daney <ddaney.cavm@gmail.com>,
	James Hogan <james.hogan@imgtec.com>, kvm@vger.kernel.org,
	David Daney <david.daney@cavium.com>
To: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from eddie.linux-mips.org ([78.24.191.182]:35678 "EHLO
	cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751147AbaEVIBd (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 22 May 2014 04:01:33 -0400
Received: from localhost.localdomain ([127.0.0.1]:54519 "EHLO linux-mips.org"
        rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP
        id S6819004AbaEVIBcBuDOS (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 22 May 2014 10:01:32 +0200
Content-Disposition: inline
In-Reply-To: <20140521210212.GH11800@alberich>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, May 21, 2014 at 11:02:12PM +0200, Andreas Herrmann wrote:

> On Wed, May 21, 2014 at 02:40:41PM +0200, Ralf Baechle wrote:
> > On Tue, May 20, 2014 at 04:47:07PM +0200, Andreas Herrmann wrote:
> > 
> > > +static inline void r4k_blast_dcache_page_dc128(unsigned long addr)
> > > +{
> > > +	R4600_HIT_CACHEOP_WAR_IMPL;
> > 
> > The R4600 has 32 byte cache lines that is this line will never be
> > executed on an R4600 thus can be dropped.
> 
> So the line can also be removed from r4k_blast_dcache_page_dc64?

Yes, indeed.  Just did that now.

  Ralf