From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v6 2/4] live migration support for initial write protect of VM Date: Tue, 27 May 2014 21:58:03 +0200 Message-ID: <20140527195803.GB16428@lvm> References: <1400178451-4984-1-git-send-email-m.smarduch@samsung.com> <1400178451-4984-3-git-send-email-m.smarduch@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, steve.capper@arm.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gavin.guo@canonical.com, peter.maydell@linaro.org, jays.lee@samsung.com, sungjinn.chung@samsung.com To: Mario Smarduch Return-path: Received: from mail-lb0-f174.google.com ([209.85.217.174]:52996 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753640AbaE0T6I (ORCPT ); Tue, 27 May 2014 15:58:08 -0400 Received: by mail-lb0-f174.google.com with SMTP id n15so5319672lbi.33 for ; Tue, 27 May 2014 12:58:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1400178451-4984-3-git-send-email-m.smarduch@samsung.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, May 15, 2014 at 11:27:29AM -0700, Mario Smarduch wrote: > Patch adds memslot support for initial write protection and split up of huge > pages I lost track of where we are with these patches, but I see a lot of issues in this patch that I believe I already commented on (but I may not have had time to comment before you sent out v6). In any case, I'm going to wait with reviewing things carefully until you send out a v7, but for v7: - Please document the rationale and design behind what you're doing in the commit text of each patch. Each of these patches are quite large, but the commit messages are barely two lines. I suggest you take a look at 'git log arch/arm/kvm' for example to get a feel for what I'm looking for. - There is nothing specific in the interface to KVM discussing migration or live migration, it is only used as an example for features in trying to stay generic. Please use similar generic concepts in the kernel to make things coherent. 'git grep migration arch/x86/kvm' also tells you that x86 gets away with full support for live migration without referring to migration except as examples of how features might be useful. Thanks for the work, looking forward to seeing a new revision. -Christoffer