From mboxrd@z Thu Jan  1 00:00:00 1970
From: Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] kvmtool: virtio: pass trapped vcpu to IO accessors
Date: Wed, 28 May 2014 14:51:46 +0100
Message-ID: <20140528135145.GH15222@arm.com>
References: <1401186259-3331-1-git-send-email-marc.zyngier@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	Pekka Enberg <penberg@kernel.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:65309 "EHLO
	cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751001AbaE1Nvu (ORCPT
	<rfc822;kvm@vger.kernel.org>); Wed, 28 May 2014 09:51:50 -0400
Content-Disposition: inline
In-Reply-To: <1401186259-3331-1-git-send-email-marc.zyngier@arm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, May 27, 2014 at 11:24:19AM +0100, Marc Zyngier wrote:
> The recent introduction of bi-endianness on arm/arm64 had the
> odd effect of breaking virtio-pci support on these platforms, as the
> device endian field defaults to being VIRTIO_ENDIAN_HOST, which
> is the wrong thing to have on a bi-endian capable architecture.
> 
> The fix is to check for the endianness on the ioport path the
> same way we do it for mmio, which implies passing the vcpu all
> the way down. Patch is a bit ugly, but aligns MMIO and ioport nicely.
> 
> Tested on arm64 and x86.
> 
> Acked-by: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Please can you pick this one up Pekka? It fixes an unfortunate regression
in PCI caused by the bi-endianness series.

Cheers,

Will