From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v4 00/19] kvm-unit-tests/arm: initial drop Date: Mon, 9 Jun 2014 11:57:02 +0200 Message-ID: <20140609095702.GN3279@lvm> References: <1397149020-3501-1-git-send-email-drjones@redhat.com> <20140606184144.GV3994@lvm> <20140609095139.GE3024@dhcp-27-201.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org To: Andrew Jones Return-path: Received: from mail-lb0-f172.google.com ([209.85.217.172]:54775 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060AbaFIJ5H (ORCPT ); Mon, 9 Jun 2014 05:57:07 -0400 Received: by mail-lb0-f172.google.com with SMTP id l4so2909406lbv.17 for ; Mon, 09 Jun 2014 02:57:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140609095139.GE3024@dhcp-27-201.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jun 09, 2014 at 11:51:40AM +0200, Andrew Jones wrote: > On Fri, Jun 06, 2014 at 08:41:44PM +0200, Christoffer Dall wrote: > > On Thu, Apr 10, 2014 at 06:56:41PM +0200, Andrew Jones wrote: > > > This is a v4 of a series that introduces arm to kvm-unit-tests. First, > > > it does some tidying up of the repo. Then, it adds support for device > > > trees (libfdt), and for virtio-testdev[1]. Next, it adds the basic > > > infrastructure for booting a test case (guest), and adds a first > > > test case, a self-test to confirm setup was completed successfully. > > > Finally, it further prepares the framework for more complicated tests > > > by adding vector support, and extends the self-test to test that too. > > > > > > This initial drop doesn't require kvmarm. qemu-system-arm is enough, > > > but it must have mach-virt, and the virtio-testdev patch[1]. > > > > > > > This is overall looking really good! > > > > I only had a few comments and questions, but you should be able to sort > > that out quickly. > > > > It's a lot of code and growing for every iteration, and this time it was > > a long gap since the last review, so it took me a while. > > > > I think it would be great if you can address my comments quickly and we > > can this merged without futher churn and let new functionality come as > > separate extra patches afterwards. > > Thanks a million for the reviewing! I'll get v5 with your acked-by's and > reviewed-by's and comments addressed sent out today or tomorrow. > Awesome! -Christoffer