Re: [PATCH v2] kvm: x86: emulate monitor and mwait instructions as nop

Paolo Bonzini
2014-06-03T09:17:54Z

Il 02/06/2014 21:25, Gabriel L. Somlo ha scritto:
> Would it make sense to make this a module parameter,
> (e.g., "int emulate_mwait") ?
>
> Default would be 0 (no emulation). 1 would mean "emulate as nop", and
> if anyone ever figures out how to do proper page-locking based
> emulation we could use 2 to enable that, etc. ?
>
> Not sure we'd want qemu to enable/disable it automatically, though...
>
> What do you all think ?

I think it's fine as it is now. :)

Paolo