Re: [PATCH v2] kvm: x86: emulate monitor and mwait instructions as nop

Paolo Bonzini
2014-06-04T16:34:27Z

Il 04/06/2014 16:44, Alexander Graf ha scritto:
>
>
>> Obviously, if you really like the current behavior better you can
>> always reject whatever patch I'll come up with, but I'd like to at
>> least try and see what it would look like :)
>
> I think it's perfectly fine to leave mwait always implemented as NOP -
> it's valid behavior.
>
> As for the CPUID exposure, that should be a pure QEMU thing. If
> overriding CPUID bits the kernel mask tells us doesn't work today, we
> should just make it possible :).

That should be the purpose of KVM_GET_EMULATED_CPUID, so MWAIT could be
added in __do_cpuid_ent_emulated. However, the corresponding QEMU
patches were never included. Borislav, can you refresh them?

Paolo