public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Zhang Haoyu" <zhanghy@sangfor.com>
To: "Jidong Xiao" <jidong.xiao@gmail.com>
Cc: KVM <kvm@vger.kernel.org>
Subject: Re: How does kvm support x2apic?
Date: Wed, 11 Jun 2014 12:53:26 +0800	[thread overview]
Message-ID: <201406111253238602170@sangfor.com> (raw)
In-Reply-To: CAG4AFWa+Jy4kcucMAQKBQkVgxGGtDNbdc7D5+ukccDirj49U2w@mail.gmail.com

>>>> Hi,
>>>>
>>>> According to this:
>>>>
>>>> https://github.com/torvalds/linux/commit/0d1de2d901f4ba0972a3886496a44fb1d3300dbd
>>>>
>>>> It looks like kvm have been supporting x2apic since kernel 2.6.32, or
>>>> even earlier.
>>>>
>>> This patch is to emulate x2apic for guest, then guest can benefit from some advantages of x2apic, like using RDMSR/WRMSR instead of mmio.
>>>
>>>> However, this following patch:
>>>>
>>>> https://github.com/torvalds/linux/commit/8d14695f9542e9e0195d6e41ddaa52c32322adf5
>>>>
>>>> Also claims that adding support for x2apic. But this later patch was
>>>> for kernel 3.9.
>>> This patch is to support virtual x2apic mode, which can virtualizing MSR-based APIC accesses by configuring MSR bitmaps,
>>> you can specify some MSR-based accesses without VM exit, the other MSR-based accesses with VM exit,
>>> which belongs to APIC virtualization from certain angle.
>> Thanks Haoyu, I am reading the Intel x2apic manual.
>>
>> http://www.intel.com/content/dam/doc/specification-update/64-architecture-x2apic-specification.pdf
>>
>> but I don't see the so called "virtual x2apic mode", it seems that the
>> manual does not mention anything about that. Do you mean that when the
>> Guest OS sets bit 10 (x2apic mode enable bit) of the it virtualized
>> IA32_APIC_BASE MSR, it is entering a virtual x2apic mode? But isn't
>> this the same as the aforementioned "emulate x2apic for guest"? Or,
>> "emulate x2apic for guest" is the foundation of "support virtual
>> x2apic mode"?
>>
>> -Jidong
>>
>Oh, I found the answer, the virtualized x2apic mode is not defined in
>the x2apic manual, but is defined in the intel SDM manual, chapter 29
>- APIC virtualization and virtual interrupts. Ignore my questions
>please, but thank you anyway.
>
Yes, virtual x2apic mode is part of APICv.
Guest has no idea about it is running in a virtual machine, 
VMM also prevent guest from enabling/disabling virtual x2apic mode or some other virtualization configurations.

>-Jidong
>
>>>>
>>>> So I am very confused:
>>>>
>>>> First, what's the difference between these two patches? Or say, does
>>>> kvm support x2apic since kernel 2.6.32, or since kernel 3.9?
>>>>
>>> kvm support x2apic since kernel 2.6.32, but not support virtual x2apic mode until kernel 3.9.
>>>
>>>> Second, can guest use x2apic even if the host does not? (Assuming qemu
>>>>has exposed this feature to guest.) The word "use" means something
>>>> like, accessing x2apic registers, setting the x2apic enable bit in
>>>> IA32_APICBASE MSR (i.e. bit 10).
>>>>
>>> Yes, you can use x2apic even if the PCPU does not support, and benefit from it, like performance bonus from MSR accesses instead of MMIO.
>>> But, if I remember correctly, if your guest does not support interrupt-remmping, you only can use physical destination mode when using x2apic,
>>> please see enable_IR_x2apic().
>>>
>>>> -Jidong


  reply	other threads:[~2014-06-11  4:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11  1:33 How does kvm support x2apic? Zhang Haoyu
2014-06-11  3:54 ` Jidong Xiao
2014-06-11  4:15   ` Jidong Xiao
2014-06-11  4:53     ` Zhang Haoyu [this message]
2014-06-11  5:08       ` Jidong Xiao
2014-06-11  5:29         ` Jidong Xiao
2014-06-11  6:27         ` Zhang Haoyu
2014-06-11  6:46           ` Jidong Xiao
2014-06-11  8:49             ` Zhang Haoyu
2014-06-11 15:12               ` Jidong Xiao
2014-06-12  0:42                 ` Zhang Haoyu
2014-06-12  3:24                   ` Jidong Xiao
  -- strict thread matches above, loose matches on Subject: below --
2014-06-10 17:30 Jidong Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201406111253238602170@sangfor.com \
    --to=zhanghy@sangfor.com \
    --cc=jidong.xiao@gmail.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox