From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v5 11/19] add minimal virtio support for devtree virtio-mmio Date: Sat, 14 Jun 2014 15:30:08 +0200 Message-ID: <20140614133008.GB14023@lvm> References: <1402495294-30737-1-git-send-email-drjones@redhat.com> <1402495294-30737-12-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, pbonzini@redhat.com To: Andrew Jones Return-path: Received: from mail-la0-f49.google.com ([209.85.215.49]:35299 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754678AbaFNNaS (ORCPT ); Sat, 14 Jun 2014 09:30:18 -0400 Received: by mail-la0-f49.google.com with SMTP id gf5so1472282lab.22 for ; Sat, 14 Jun 2014 06:30:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1402495294-30737-12-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jun 11, 2014 at 04:01:26PM +0200, Andrew Jones wrote: > Support the bare minimum of virtio to enable access to the virtio-mmio > config space of a device. Currently this implementation must use a > device tree to find the device. > > Signed-off-by: Andrew Jones > --- > v5: > - use same virtio struct names as kernel > - no need to alloc a new virtio_config_ops for each virtio device > - use ioremap > v4: > - split from the virtio-testdev patch > - search a table to "discover" that the device must be DT/virtio-mmio, > which doesn't change anything, but looks less hacky than comments > saying the device must be DT/virtio-mmio... > - manage own pool of virtio-mmio pre-allocated device structures in > order to avoid needing access to the heap > --- Reviewed-by: Christoffer Dall