From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH 1/6] PPC: Add asm helpers for BE 32bit load/store Date: Tue, 17 Jun 2014 10:51:24 +1000 Message-ID: <20140617005124.GA16554@iris.ozlabs.ibm.com> References: <1402482831-8941-1-git-send-email-agraf@suse.de> <1402482831-8941-2-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, anton@samba.org, Benjamin Herrenschmidt To: Alexander Graf Return-path: Received: from ozlabs.org ([103.22.144.67]:49476 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753336AbaFQBCV (ORCPT ); Mon, 16 Jun 2014 21:02:21 -0400 Content-Disposition: inline In-Reply-To: <1402482831-8941-2-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jun 11, 2014 at 12:33:46PM +0200, Alexander Graf wrote: > >From assembly code we might not only have to explicitly BE access 64bit values, > but sometimes also 32bit ones. Add helpers that allow for easy use of lwzx/stwx > in their respective byte-reverse or native form. > > Signed-off-by: Alexander Graf > CC: Benjamin Herrenschmidt > --- > arch/powerpc/include/asm/asm-compat.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/powerpc/include/asm/asm-compat.h b/arch/powerpc/include/asm/asm-compat.h > index 4b237aa..21164ff 100644 > --- a/arch/powerpc/include/asm/asm-compat.h > +++ b/arch/powerpc/include/asm/asm-compat.h > @@ -34,10 +34,14 @@ > #define PPC_MIN_STKFRM 112 > > #ifdef __BIG_ENDIAN__ > +#define LWZX_BE stringify_in_c(lwzx) > #define LDX_BE stringify_in_c(ldx) > +#define STDX_BE stringify_in_c(stwx) This should be STWX_BE, shouldn't it? > #define STDX_BE stringify_in_c(stdx) > #else > +#define LWZX_BE stringify_in_c(lwbrx) > #define LDX_BE stringify_in_c(ldbrx) > +#define STWX_BE stringify_in_c(stwbrx) > #define STDX_BE stringify_in_c(stdbrx) > #endif Paul.