From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [RFC PATCH 2/6] arm/arm64: KVM: Rename irq_active to irq_queued
Date: Mon, 30 Jun 2014 14:20:53 -0700
Message-ID: <20140630212053.GA20104@cbox>
References: <1402779067-34478-1-git-send-email-christoffer.dall@linaro.org>
 <1402779067-34478-3-git-send-email-christoffer.dall@linaro.org>
 <40b2b2cd240d39950a3aa98c53c36fad@www.loen.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org,
	Andre Przywara <andre.przywara@arm.com>, kvm@vger.kernel.org
To: Marc Zyngier <maz@misterjones.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-la0-f52.google.com ([209.85.215.52]:52251 "EHLO
	mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751224AbaF3VUu (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 30 Jun 2014 17:20:50 -0400
Received: by mail-la0-f52.google.com with SMTP id ty20so5321617lab.11
        for <kvm@vger.kernel.org>; Mon, 30 Jun 2014 14:20:48 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <40b2b2cd240d39950a3aa98c53c36fad@www.loen.fr>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Jun 22, 2014 at 12:25:02PM +0100, Marc Zyngier wrote:
> On 2014-06-14 21:51, Christoffer Dall wrote:
> >We have a special bitmap on the distributor struct to keep track
> >of when
> >level-triggered interrupts are queued on the list registers.  This
> >was
> >named irq_active, which is confusing, because the active state of an
> >interrupt as per the GIC spec is a different thing, not specifically
> >related to edge-triggered/level-triggered configurations but rather
> >indicates an interrupt which has been ack'ed but not yet eoi'ed.
> >
> >Rename the bitmap and the corresponding accessor functions to
> >irq_queued
> >to clarify what this is actually used for.
> 
> While I agree that irq_active is confusing, I would tend to object
> to irq_queued for similar reasons. Edge interrupts get queued as
> well.

yeah, but this is never checked for edge-triggered IRQs so I don't find
that part confusing.  I find the queued word suitable, because we set in
in the _queue function and unset it in the unqueue function.

> 
> What this bit does is to allow or forbid resampling of a level
> interrupt.
> 
> How about irq_resample instead? That would mandate a small refactor
> of the code (a bit set to one would allow resampling, which is the
> opposite of the current logic), but would look better, I believe.
> 
> What do you think?
> 
hmm, maybe.  Feel like illustrating what you mean exactly in form of a
patch?

-Christoffer