From: Gleb Natapov <gleb@kernel.org>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, laijs@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] kvm, memory-hotplug: Update ept identity pagetable when it is migrated.
Date: Wed, 2 Jul 2014 19:34:20 +0300 [thread overview]
Message-ID: <20140702163420.GC4399@minantech.com> (raw)
In-Reply-To: <1404291637-15048-4-git-send-email-tangchen@cn.fujitsu.com>
On Wed, Jul 02, 2014 at 05:00:36PM +0800, Tang Chen wrote:
> ept identity pagetable is pinned in memory, and as a result it cannot be
> migrated/hot-removed.
>
> But actually it doesn't need to be pinned in memory.
>
> This patch introduces a new vcpu request: KVM_REQ_MIGRATE_EPT to reset ept
> indetity pagetable related variable. This request will be made when
> kvm_mmu_notifier_invalidate_page() is called when the page is unmapped
> from the qemu user space to reset kvm->arch.ept_identity_pagetable to NULL.
> And will also be made when ept violation happens to reset
> kvm->arch.ept_identity_pagetable to the new page.
kvm->arch.ept_identity_pagetable is never used as a page address, just
boolean null/!null to see if identity pagetable is initialized. I do
not see why would we want to track its address at all. Changing it to bool
and assigning true during initialization should be enough.
--
Gleb.
next prev parent reply other threads:[~2014-07-02 16:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 9:00 [PATCH 0/4] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-07-02 9:00 ` [PATCH 1/4] kvm: Add gfn_to_page_no_pin() Tang Chen
2014-07-02 9:00 ` [PATCH 2/4] kvm: Add macro VMX_APIC_ACCESS_PAGE_ADDR Tang Chen
2014-07-02 16:24 ` Gleb Natapov
2014-07-03 1:19 ` Tang Chen
2014-07-02 9:00 ` [PATCH 3/4] kvm, memory-hotplug: Update ept identity pagetable when it is migrated Tang Chen
2014-07-02 16:34 ` Gleb Natapov [this message]
2014-07-03 1:19 ` Tang Chen
2014-07-04 2:36 ` Tang Chen
2014-07-04 9:49 ` Gleb Natapov
2014-07-02 9:00 ` [PATCH 4/4] kvm, mem-hotplug: Update apic access page " Tang Chen
2014-07-03 13:55 ` Gleb Natapov
2014-07-04 2:18 ` Tang Chen
2014-07-04 2:18 ` Tang Chen
2014-07-04 10:13 ` Gleb Natapov
2014-07-07 6:17 ` Tang Chen
2014-07-07 9:52 ` Tang Chen
2014-07-07 11:42 ` Nadav Amit
2014-07-07 11:54 ` Gleb Natapov
2014-07-07 12:10 ` Nadav Amit
2014-07-07 12:15 ` Gleb Natapov
[not found] ` <1408522330-18009-1-git-send-email-namit@cs.technion.ac.il>
2014-08-20 8:44 ` [PATCH] KVM: x86: Warn on APIC base relocation Nadav Amit
2014-07-08 1:44 ` [PATCH 4/4] kvm, mem-hotplug: Update apic access page when it is migrated Tang Chen
2014-07-08 6:46 ` Nadav Amit
2014-07-07 10:35 ` Wanpeng Li
2014-07-08 9:40 ` Tang Chen
2014-07-03 1:17 ` [PATCH 0/4] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-07-03 6:04 ` Gleb Natapov
2014-07-04 6:41 ` Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702163420.GC4399@minantech.com \
--to=gleb@kernel.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox