From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v3 1/9] arm64: KVM: rename pm_fake handler to trap_raz_wi Date: Wed, 9 Jul 2014 02:27:12 -0700 Message-ID: <20140709092712.GA19801@cbox> References: <1403269207-1625-1-git-send-email-marc.zyngier@arm.com> <1403269207-1625-2-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Anup Patel To: Marc Zyngier Return-path: Received: from mail-la0-f43.google.com ([209.85.215.43]:40397 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbaGIJ05 (ORCPT ); Wed, 9 Jul 2014 05:26:57 -0400 Received: by mail-la0-f43.google.com with SMTP id e16so4844592lan.16 for ; Wed, 09 Jul 2014 02:26:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1403269207-1625-2-git-send-email-marc.zyngier@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jun 20, 2014 at 01:59:59PM +0100, Marc Zyngier wrote: > pm_fake doesn't quite describe what the handler does (ignoring writes > and returning 0 for reads). > > As we're about to use it (a lot) in a different context, rename it > with a (admitedly cryptic) name that make sense for all users. > > Reviewed-by: Anup Patel > Signed-off-by: Marc Zyngier didn't I already review this? Did something change, it doesn't look like it from the changelog.... /me confused.