From: mtosatti@redhat.com
To: kvm@vger.kernel.org, ak@linux.intel.com
Cc: pbonzini@redhat.com, xiaoguangrong@linux.vnet.ibm.com,
gleb@kernel.org, avi.kivity@gmail.com
Subject: [patch 4/4] KVM: MMU: pinned sps are not candidates for deletion.
Date: Wed, 09 Jul 2014 16:12:54 -0300 [thread overview]
Message-ID: <20140709191611.349481802@amt.cnet> (raw)
In-Reply-To: 20140709191250.408928362@amt.cnet
[-- Attachment #1: mmu-pinned-spte-skip --]
[-- Type: text/plain, Size: 1732 bytes --]
Skip pinned shadow pages when selecting pages to zap.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
arch/x86/kvm/mmu.c | 26 ++++++++++++++++++--------
1 file changed, 18 insertions(+), 8 deletions(-)
Index: kvm.pinned-sptes/arch/x86/kvm/mmu.c
===================================================================
--- kvm.pinned-sptes.orig/arch/x86/kvm/mmu.c 2014-07-09 12:09:26.433674438 -0300
+++ kvm.pinned-sptes/arch/x86/kvm/mmu.c 2014-07-09 12:09:27.164672860 -0300
@@ -2267,16 +2267,24 @@
static bool prepare_zap_oldest_mmu_page(struct kvm *kvm,
struct list_head *invalid_list)
{
- struct kvm_mmu_page *sp;
-
- if (list_empty(&kvm->arch.active_mmu_pages))
- return false;
+ struct kvm_mmu_page *sp, *nsp;
+ LIST_HEAD(pinned_list);
- sp = list_entry(kvm->arch.active_mmu_pages.prev,
- struct kvm_mmu_page, link);
- kvm_mmu_prepare_zap_page(kvm, sp, invalid_list);
+ list_for_each_entry_safe_reverse(sp, nsp,
+ &kvm->arch.active_mmu_pages, link) {
+ if (sp->pinned) {
+ list_move(&sp->link, &pinned_list);
+ continue;
+ }
+ if (!list_empty(&pinned_list))
+ list_move(&pinned_list, &kvm->arch.active_mmu_pages);
+ kvm_mmu_prepare_zap_page(kvm, sp, invalid_list);
+ return true;
+ }
- return true;
+ if (!list_empty(&pinned_list))
+ list_move(&pinned_list, &kvm->arch.active_mmu_pages);
+ return false;
}
/*
@@ -4679,6 +4687,8 @@
* Notify all vcpus to reload its shadow page table
* and flush TLB. Then all vcpus will switch to new
* shadow page table with the new mmu_valid_gen.
+ * MMU reload request also forces fault of
+ * sptes for pinned ranges.
*
* Note: we should do this under the protection of
* mmu-lock, otherwise, vcpu would purge shadow page
next prev parent reply other threads:[~2014-07-09 19:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 19:12 [patch 0/4] KVM: support for pinning sptes (v2) mtosatti
2014-07-09 19:12 ` [patch 1/4] KVM: x86: add pinned parameter to page_fault methods mtosatti
2014-07-09 19:12 ` [patch 2/4] KVM: MMU: allow pinning spte translations (TDP-only) mtosatti
2014-07-17 17:18 ` Nadav Amit
2014-07-17 21:38 ` Marcelo Tosatti
2014-07-24 12:16 ` Nadav Amit
2014-07-21 21:46 ` Xiao Guangrong
2014-07-22 5:26 ` Xiao Guangrong
2014-07-09 19:12 ` [patch 3/4] KVM: MMU: reload request from GET_DIRTY_LOG path mtosatti
2014-07-21 13:14 ` Gleb Natapov
2014-09-09 15:28 ` Marcelo Tosatti
2014-09-22 17:19 ` Marcelo Tosatti
2014-09-30 18:59 ` Marcelo Tosatti
2014-10-04 7:23 ` Gleb Natapov
2014-10-06 17:19 ` Marcelo Tosatti
2014-10-08 6:56 ` Gleb Natapov
2014-10-08 17:15 ` Marcelo Tosatti
2014-10-08 17:59 ` Gleb Natapov
2014-10-08 19:22 ` Marcelo Tosatti
2014-10-10 13:09 ` Gleb Natapov
2014-10-13 8:52 ` Marcelo Tosatti
2014-10-15 8:03 ` Gleb Natapov
2014-07-21 21:55 ` Xiao Guangrong
2014-09-09 15:35 ` Marcelo Tosatti
2014-07-09 19:12 ` mtosatti [this message]
2014-07-21 21:59 ` [patch 4/4] KVM: MMU: pinned sps are not candidates for deletion Xiao Guangrong
2014-09-09 15:41 ` Marcelo Tosatti
2014-09-22 17:17 ` Marcelo Tosatti
2014-09-23 5:30 ` Xiao Guangrong
2014-07-09 19:20 ` [patch 0/4] KVM: support for pinning sptes (v2) Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709191611.349481802@amt.cnet \
--to=mtosatti@redhat.com \
--cc=ak@linux.intel.com \
--cc=avi.kivity@gmail.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox