Re: [PATCH 35/38] unicore32: clean-up uapi Kbuild file

James Hogan
2014-07-15T10:53:52Z

On 14/07/14 16:09, Sam Ravnborg wrote:
> Remove redundant assignments.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> ---
> arch/unicore32/include/uapi/asm/Kbuild | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/arch/unicore32/include/uapi/asm/Kbuild b/arch/unicore32/include/uapi/asm/Kbuild
> index 0514d7a..aff532f 100644
> --- a/arch/unicore32/include/uapi/asm/Kbuild
> +++ b/arch/unicore32/include/uapi/asm/Kbuild
> @@ -1,10 +1,5 @@
> # UAPI Header export list
> include include/uapi/asm-generic/Kbuild.asm
>
> -header-y += byteorder.h
> -header-y += kvm_para.h
> -header-y += ptrace.h
> -header-y += sigcontext.h
> -header-y += unistd.h
> -
> +# Wapper from asm-generic
> generic-y += kvm_para.h
>

You dropped the generic-y += kvm_para.h for arm64 & c6x, but not for
unicore, avr32 & ia64 patch, which seems a bit inconsistent. Was there
some reason behind that?

AFACT the non-uapi kvm_para.h is needed (e.g. by using the generic
non-uapi one) by kernel/watchdog.c for
kvm_check_and_clear_guest_paused(), so all arches should have at least
generic-y += kvm_para.h (or their own one) for non-uapi, even if they
have a uapi one too.

For UAPI, they're presumably only needed for architectures which support
KVM (s390, ia64, arm, powerpc, arm64, mips, x86 all provide an asm/kvm.h).

Is that right? Clearly there's some cleanup to do for kvm_para.h (which
is what made me look at the header issues previously).

Cheers
James