From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH v7 08/14] Introduce chr-testdev Date: Wed, 16 Jul 2014 11:33:12 +0200 Message-ID: <20140716093312.GA14882@hawk.usersys.redhat.com> References: <1405500463-20713-1-git-send-email-drjones@redhat.com> <1405500463-20713-9-git-send-email-drjones@redhat.com> <1124400215.1863219.1405503093424.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer dall , pbonzini@redhat.com To: Levente Kurusa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49241 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbaGPJdT (ORCPT ); Wed, 16 Jul 2014 05:33:19 -0400 Content-Disposition: inline In-Reply-To: <1124400215.1863219.1405503093424.JavaMail.zimbra@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 16, 2014 at 05:31:33AM -0400, Levente Kurusa wrote: > ----- Original Message ----- > > [...] > > +void chr_testdev_exit(int code) > > +{ > > + char buf[8]; > > + int len; > > + > > + snprintf(buf, sizeof(buf), "%dq", code); > > + len = strlen(buf); > > AFAIK, snprintf returns the number of characters written, so > these two statements can be merged into one. You are correct. I'll do this for v8 (if a v8 is needed). Thanks, drew