From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH v2 1/2] contrib: add ivshmem client and server Date: Mon, 21 Jul 2014 15:30:01 +0100 Message-ID: <20140721143001.GF3829@redhat.com> References: <1405849119-13569-1-git-send-email-david.marchand@6wind.com> <1405849119-13569-2-git-send-email-david.marchand@6wind.com> <53CD21E1.1010908@redhat.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: David Marchand , qemu-devel@nongnu.org, Olivier Matz , kvm@vger.kernel.org, claudio.fontana@huawei.com, pbonzini@redhat.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca To: Eric Blake Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52310 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754125AbaGUOaV (ORCPT ); Mon, 21 Jul 2014 10:30:21 -0400 Content-Disposition: inline In-Reply-To: <53CD21E1.1010908@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jul 21, 2014 at 08:21:21AM -0600, Eric Blake wrote: > On 07/20/2014 03:38 AM, David Marchand wrote: > > When using ivshmem devices, notifications between guests can be sent as > > interrupts using a ivshmem-server (typical use described in documentation). > > The client is provided as a debug tool. > > > > Signed-off-by: Olivier Matz > > Signed-off-by: David Marchand > > --- > > contrib/ivshmem-client/Makefile | 26 ++ > > > +++ b/contrib/ivshmem-client/Makefile > > @@ -0,0 +1,26 @@ > > +# Copyright 2014 6WIND S.A. > > +# All rights reserved > > This file has no other license, and is therefore incompatible with > GPLv2. You'll need to resubmit under an appropriately open license. > > > +++ b/contrib/ivshmem-client/ivshmem-client.h > > @@ -0,0 +1,238 @@ > > +/* > > + * Copyright(c) 2014 6WIND S.A. > > + * All rights reserved. > > + * > > + * This work is licensed under the terms of the GNU GPL, version 2. See > > + * the COPYING file in the top-level directory. > > I'm not a lawyer, but to me, this license is self-contradictory. You > can't have "All rights reserved" and still be GPL, because the point of > the GPL is that you are NOT reserving all rights, but explicitly > granting your user various rights (on condition that they likewise grant > those rights to others). But you're not the only file in the qemu code > base with this questionable mix. In any case adding the term 'All rights reserved' is said to be redundant obsolete these days https://en.wikipedia.org/wiki/All_rights_reserved#Obsolescence Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|