public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ethan Zhao <ethan.zhao@oracle.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, gleb@kernel.org,
	pbonzini@redhat.com, kvm@vger.kernel.org,
	boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
	xen-devel@lists.xenproject.org, alex.williamson@redhat.com,
	alexander.h.duyck@intel.com, ethan.kernel@gmail.com
Subject: Re: [PATCH 3/4] xen-pciback: use pci device flag operation helper function
Date: Tue, 22 Jul 2014 13:34:44 -0400	[thread overview]
Message-ID: <20140722173444.GB14061@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <1406045944-1587-4-git-send-email-ethan.zhao@oracle.com>

On Wed, Jul 23, 2014 at 12:19:03AM +0800, Ethan Zhao wrote:
> Use pci device flag operation helper functions when set device
> to assigned or deassigned state.
> 
> Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  drivers/xen/xen-pciback/pci_stub.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
> index 62fcd48..71f69f1 100644
> --- a/drivers/xen/xen-pciback/pci_stub.c
> +++ b/drivers/xen/xen-pciback/pci_stub.c
> @@ -133,7 +133,7 @@ static void pcistub_device_release(struct kref *kref)
>  	xen_pcibk_config_free_dyn_fields(dev);
>  	xen_pcibk_config_free_dev(dev);
>  
> -	dev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED;
> +	pci_set_dev_deassigned(dev);
>  	pci_dev_put(dev);
>  
>  	kfree(psdev);
> @@ -404,7 +404,7 @@ static int pcistub_init_device(struct pci_dev *dev)
>  	dev_dbg(&dev->dev, "reset device\n");
>  	xen_pcibk_reset_device(dev);
>  
> -	dev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED;
> +	pci_set_dev_assigned(dev);
>  	return 0;
>  
>  config_release:
> -- 
> 1.7.1
> 

  reply	other threads:[~2014-07-22 17:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 16:19 [PATCH 0/4] Introduce device assignment flag operation helper function Ethan Zhao
2014-07-22 16:19 ` [PATCH 1/4] PCI: introduce helper functions for device flag operation Ethan Zhao
2014-07-28 21:00   ` Alex Williamson
2014-07-29  1:53     ` ethan zhao
2014-07-29  2:31       ` Alex Williamson
2014-07-29  2:43         ` ethan zhao
2014-07-29  3:37           ` Alexander Duyck
2014-07-29  3:47             ` Ethan Zhao
2014-07-22 16:19 ` [PATCH 2/4] KVM: use pci device flag operation helper functions Ethan Zhao
2014-07-24 11:09   ` Paolo Bonzini
2014-07-22 16:19 ` [PATCH 3/4] xen-pciback: use pci device flag operation helper function Ethan Zhao
2014-07-22 17:34   ` Konrad Rzeszutek Wilk [this message]
2014-07-22 16:19 ` [PATCH 4/4] PCI: use device flag operation helper function in iov.c Ethan Zhao
  -- strict thread matches above, loose matches on Subject: below --
2014-08-08  5:36 [PATCH v3 0/4 resend] Introduce device assignment flag operation helper function Ethan Zhao
2014-08-08  5:36 ` [PATCH 3/4] xen-pciback: use pci device " Ethan Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140722173444.GB14061@konrad-lan.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=alex.williamson@redhat.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=bhelgaas@google.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=ethan.kernel@gmail.com \
    --cc=ethan.zhao@oracle.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox