From mboxrd@z Thu Jan  1 00:00:00 1970
From: Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v2 2/4] KVM: ARM: vgic: register kvm_device_ops
 dynamically
Date: Thu, 31 Jul 2014 14:25:12 +0100
Message-ID: <20140731132511.GV26853@arm.com>
References: <1404225918-8903-1-git-send-email-will.deacon@arm.com>
 <1404225918-8903-2-git-send-email-will.deacon@arm.com>
 <20140731121015.GG11610@cbox>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
	"Alex.Williamson@redhat.com" <Alex.Williamson@redhat.com>,
	"agraf@suse.de" <agraf@suse.de>,
	"gleb@kernel.org" <gleb@kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:59126 "EHLO
	cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751388AbaGaNZY (ORCPT
	<rfc822;kvm@vger.kernel.org>); Thu, 31 Jul 2014 09:25:24 -0400
Content-Disposition: inline
In-Reply-To: <20140731121015.GG11610@cbox>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Christoffer,

On Thu, Jul 31, 2014 at 01:10:15PM +0100, Christoffer Dall wrote:
> On Tue, Jul 01, 2014 at 03:45:16PM +0100, Will Deacon wrote:
> > Now that we have a dynamic means to register kvm_device_ops, use that
> > for the ARM VGIC, instead of relying on the static table.
> > 
> > Cc: Gleb Natapov <gleb@kernel.org>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Christoffer Dall <christoffer.dall@linaro.org>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > ---
> >  include/linux/kvm_host.h |   1 -
> >  virt/kvm/arm/vgic.c      | 156 +++++++++++++++++++++++------------------------
> >  virt/kvm/kvm_main.c      |   4 --
> >  3 files changed, 78 insertions(+), 83 deletions(-)

[...]

> > +	if (ret) {
> > +		kvm_err("Cannot register vgic CPU notifier\n");
> > +		goto out_free_irq;
> > +	}
> > +
> > +	on_each_cpu(vgic_init_maintenance_interrupt, NULL, 1);
> > +
> > +	/* Callback into for arch code for setup */
> > +	vgic_arch_setup(vgic);
> 
> close to ridiculous nit: but I would add a newline here since the
> comment doesn't really apply to the kvm_register_device_ops, but please
> don't make another revision just for this.

I'll repost this after the merge window anyway, so there's plenty of room
for pedantic, cosmetic changes!

Thanks,

Will