From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 3/5] kvmtool: ARM64: Add target type potenza for aarch64 Date: Thu, 7 Aug 2014 10:01:31 +0100 Message-ID: <20140807090131.GA13703@arm.com> References: <1407228599-25065-1-git-send-email-anup.patel@linaro.org> <1407228599-25065-4-git-send-email-anup.patel@linaro.org> <20140806125210.GO25953@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "patches@apm.com" , Marc Zyngier , "penberg@kernel.org" , "christoffer.dall@linaro.org" , "pranavkumar@linaro.org" To: Anup Patel Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:41166 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754303AbaHGJBe (ORCPT ); Thu, 7 Aug 2014 05:01:34 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Aug 07, 2014 at 09:56:28AM +0100, Anup Patel wrote: > On 6 August 2014 18:22, Will Deacon wrote: > > On Tue, Aug 05, 2014 at 09:49:57AM +0100, Anup Patel wrote: > >> The VCPU target type KVM_ARM_TARGET_XGENE_POTENZA is available > >> in latest Linux-3.16-rcX or higher hence register aarch64 target > >> type for it. > >> > >> This patch enables us to run KVMTOOL on X-Gene Potenza host. > >> > >> Signed-off-by: Pranavkumar Sawargaonkar > >> Signed-off-by: Anup Patel > >> --- > >> tools/kvm/arm/aarch64/arm-cpu.c | 9 ++++++++- > >> 1 file changed, 8 insertions(+), 1 deletion(-) > >> > >> diff --git a/tools/kvm/arm/aarch64/arm-cpu.c b/tools/kvm/arm/aarch64/arm-cpu.c > >> index ce5ea2f..ce526e3 100644 > >> --- a/tools/kvm/arm/aarch64/arm-cpu.c > >> +++ b/tools/kvm/arm/aarch64/arm-cpu.c > >> @@ -41,10 +41,17 @@ static struct kvm_arm_target target_cortex_a57 = { > >> .init = arm_cpu__vcpu_init, > >> }; > >> > >> +static struct kvm_arm_target target_potenza = { > >> + .id = KVM_ARM_TARGET_XGENE_POTENZA, > >> + .compatible = "arm,arm-v8", > >> + .init = arm_cpu__vcpu_init, > >> +}; > > > > This implies you have the same PPIs for the arch-timer as the Cortex-A CPUs. > > Is that right? > > Currently, KVM ARM64 provides PPI27 as arch-time IRQ for all target types. > > This will have to change if KVM ARM64 starts using different > arch-timer PPI based on target type. Oh, of course, these are virtual interrupt numbers. Ignore me! Will