public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Eric Auger <eric.auger@linaro.org>
Subject: Re: [PATCH 0/6] IRQFD without IRQ routing, enabled for XICS
Date: Thu, 7 Aug 2014 19:49:20 +1000	[thread overview]
Message-ID: <20140807094920.GC28639@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <53E22111.3040902@redhat.com>

On Wed, Aug 06, 2014 at 02:35:29PM +0200, Paolo Bonzini wrote:

> This doesn't build without CONFIG_KVM_XICS, so I had to apply a fixup
> patch to move some code from being under CONFIG_HAVE_KVM_IRQCHIP or
> unconditional, to being conditional on CONFIG_HAVE_KVM_IRQFD.  I'll send
> the patch shortly.

Oops, sorry, thanks for fixing it up.

> Also, please look into adding a trace_kvm_set_irq call to kvm_set_irq in
> arch/powerpc/kvm/book3s_xics.c.
> 
> I would have preferred these snags to be fixed before (especially since
> the breakage is simply with "make ppc64_defconfig"), but it's partly my
> fault for delaying the review for so long.  And the series is good work

... and I have been on vacation for the past three weeks, which didn't
help either.

> and a very nice cleanup of the irqfd architecture.
> 
> Assuming that the linux-next merge from tomorrow is fine, I'll send the
> second pull request to Linus.

Thanks,
Paul.

      reply	other threads:[~2014-08-07  9:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 10:51 [PATCH 0/6] IRQFD without IRQ routing, enabled for XICS Paul Mackerras
2014-06-30 10:51 ` [PATCH 1/6] KVM: Don't keep reference to irq routing table in irqfd struct Paul Mackerras
2014-06-30 10:51 ` [PATCH 2/6] KVM: irqchip: Provide and use accessors for irq routing table Paul Mackerras
2014-06-30 10:51 ` [PATCH 3/6] KVM: Move all accesses to kvm::irq_routing into irqchip.c Paul Mackerras
2014-06-30 10:51 ` [PATCH 4/6] KVM: Move irq notifier implementation into eventfd.c Paul Mackerras
2014-06-30 10:51 ` [PATCH 5/6] KVM: Give IRQFD its own separate enabling Kconfig option Paul Mackerras
2014-06-30 10:51 ` [PATCH 6/6] KVM: PPC: Enable IRQFD support for the XICS interrupt controller Paul Mackerras
2014-06-30 12:43 ` [PATCH 0/6] IRQFD without IRQ routing, enabled for XICS Alexander Graf
2014-06-30 21:25   ` Paul Mackerras
2014-07-13 22:30 ` Paul Mackerras
2014-07-14 14:18 ` Cornelia Huck
2014-07-24 15:47   ` Eric Auger
2014-08-05 12:27 ` Paolo Bonzini
2014-08-06 12:35   ` Paolo Bonzini
2014-08-07  9:49     ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140807094920.GC28639@iris.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=agraf@suse.de \
    --cc=eric.auger@linaro.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox